From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6690 invoked by alias); 26 May 2017 13:03:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6538 invoked by uid 89); 26 May 2017 13:03:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=bearing, cx, Including, Hx-languages-length:1553 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 May 2017 13:02:55 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dEEtK-0001av-2g for gdb-patches@sourceware.org; Fri, 26 May 2017 09:02:57 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43358) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dEEtJ-0001ar-Vn; Fri, 26 May 2017 09:02:54 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1075 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dEEtJ-0005PH-0J; Fri, 26 May 2017 09:02:53 -0400 Date: Fri, 26 May 2017 13:03:00 -0000 Message-Id: <83h907kbyg.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: brobecker@adacore.com, simon.marchi@polymtl.ca, gdb-patches@sourceware.org In-reply-to: <209349d7-a2b5-74ab-3b49-553d6e9ed97e@redhat.com> (message from Pedro Alves on Fri, 26 May 2017 11:54:03 +0100) Subject: Re: GDB 7.99.91 MinGW compilation error in cli-script.c Reply-to: Eli Zaretskii References: <83fug35v70.fsf@gnu.org> <83y3tt2ow0.fsf@gnu.org> <83vaox2j0w.fsf@gnu.org> <7017128a-7b51-5436-657b-58807d04eb02@redhat.com> <83vaouns1q.fsf@gnu.org> <837f18ohr2.fsf@gnu.org> <54594002-5d70-9ff8-c481-0cbfc8c68c7b@redhat.com> <834lwam7n4.fsf@gnu.org> <20170524193716.5arjibe4s5efvgj7@adacore.com> <15568468-0852-d786-8777-4adbd16825a0@redhat.com> <83tw48jc0f.fsf@gnu.org> <209349d7-a2b5-74ab-3b49-553d6e9ed97e@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00560.txt.bz2 > Cc: brobecker@adacore.com, simon.marchi@polymtl.ca, gdb-patches@sourceware.org > From: Pedro Alves > Date: Fri, 26 May 2017 11:54:03 +0100 > > > The code says std::to_string, though. So it sounds like some coding > > conventions are being applied here of which I wasn't aware, and > > neither is Emacs. Are these conventions described somewhere? > > Just the standard GNU conventions. The code is defining a new > function template called gdb::to_string. Simplified: > > namespace gdb { > template std::string to_string (const T &val); > } > > There are two implementations of that, one for mingw, written > as a new function template in place. And another which is > importing std::to_string into the gdb namespace. But whatever > the implementations, it's implementation detail of gdb::to_string. So the convention is to include the full qualifier of every method? Including the namespace of the class? Does that include the whole chain of namespaces up to the root? If not, where does one stop? > > but once again, the convention to put the > > fully-qualified symbol name in the log entry should be documented, if > > it isn't already, because Emacs doesn't do that, at least not by > > default. > > I can't see how what Emacs does has any bearing here, since AFAIK, > Emacs isn't written in C++. I use Emacs commands, such as "C-x 4 a", to generate ChangeLog entries. Don't you do the same? Emacs add-log commands strip the class and namespace qualifiers.