From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126136 invoked by alias); 13 Jun 2017 14:49:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126115 invoked by uid 89); 13 Jun 2017 14:49:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Jun 2017 14:49:34 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKn8Q-0006F0-U5 for gdb-patches@sourceware.org; Tue, 13 Jun 2017 10:49:38 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44638) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKn8Q-0006Et-Q9; Tue, 13 Jun 2017 10:49:34 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4480 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dKn8Q-0004EM-3K; Tue, 13 Jun 2017 10:49:34 -0400 Date: Tue, 13 Jun 2017 14:49:00 -0000 Message-Id: <83h8zk3pu3.fsf@gnu.org> From: Eli Zaretskii To: Yao Qi CC: gdb-patches@sourceware.org In-reply-to: <86wp8gccqv.fsf@gmail.com> (message from Yao Qi on Tue, 13 Jun 2017 13:07:20 +0100) Subject: Re: [PATCH 06/25] Generate c for feature instead of tdesc Reply-to: Eli Zaretskii References: <1497256916-4958-1-git-send-email-yao.qi@linaro.org> <1497256916-4958-7-git-send-email-yao.qi@linaro.org> <837f0h5kjz.fsf@gnu.org> <86wp8gccqv.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00387.txt.bz2 > From: Yao Qi > Cc: gdb-patches@sourceware.org > Date: Tue, 13 Jun 2017 13:07:20 +0100 > > > . "The created source file can be used in GDB ..." -- used how? I'd > > prefer that we said a sentence or tow about that as well, or had a > > cross-reference to where that is described. > > The created source file is built into GDB. Sorry, I don't understand: built into GDB how? The GDB in which the user runs this command can then turn around and have the produced file built into it? > How is the doc and NEWS entry below? OK, with two comments, see below. > @kindex maint print c-tdesc @r{[}@var{file}@r{]} > @item maint print c-tdesc > Print the target description (@pxref{Target Descriptions}) as > a C source file. By default, the target description is for the current > target, but if the optional argument @var{file} is provided, that file > is used to produce the description. The @var{file} is an XML document, ^^ "should be" > of the form described in @ref{Target Description Format}. The created > source file is built in @value{GDBN}. ^^ "into" > > Also, what about a NEWS entry? > > * The "maintenance print c-tdesc" command now takes an optional > argument which is the file name of XML target description. This is OK. Thanks.