From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-155388-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 72908 invoked by alias); 17 Apr 2019 14:35:40 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 71803 invoked by uid 89); 17 Apr 2019 14:35:39 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Apr 2019 14:35:38 +0000
Received: from fencepost.gnu.org ([2001:470:142:3::e]:41853)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1hGlew-0002A3-CB; Wed, 17 Apr 2019 10:35:36 -0400
Received: from [176.228.60.248] (port=1689 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1hGler-0002hK-Kf; Wed, 17 Apr 2019 10:35:30 -0400
Date: Wed, 17 Apr 2019 14:35:00 -0000
Message-Id: <83h8awg0nk.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
CC: gdb-patches@sourceware.org
In-reply-to:	<5cbfdd5672b59422d41f4b3c0ca20a9d45c20442.1555455013.git.andrew.burgess@embecosm.com>	(message from Andrew Burgess on Wed, 17 Apr 2019 00:06:10 +0100)
Subject: Re: [PATCHv2 5/5] gdb: Introduce 'print max-depth' feature
References: <cover.1553723416.git.andrew.burgess@embecosm.com> <cover.1555455013.git.andrew.burgess@embecosm.com> <cover.1555455013.git.andrew.burgess@embecosm.com> <5cbfdd5672b59422d41f4b3c0ca20a9d45c20442.1555455013.git.andrew.burgess@embecosm.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-IsSubscribed: yes
X-SW-Source: 2019-04/txt/msg00293.txt.bz2

> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Cc: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Wed, 17 Apr 2019 00:06:10 +0100
> 
> Introduce a new print setting max-depth which can be set with 'set
> print max-depth DEPTH'.  The default value of DEPTH is 20, but this
> can also be set to unlimited.

OK for the documentation parts, with one minor comment:

> +To see the contents of structures that have been hidden the user can
> +either increase the print max-depth to increase, or they can print

"increase ... to increase" sounds awkward and perhaps even confusing.
Can we come up with a better wording?

Thanks.