From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-156682-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 38972 invoked by alias); 7 Jun 2019 07:36:52 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 38795 invoked by uid 89); 7 Jun 2019 07:36:52 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-15.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:784
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Jun 2019 07:36:51 +0000
Received: from fencepost.gnu.org ([2001:470:142:3::e]:58972)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1hZ9Qf-0005yf-TH; Fri, 07 Jun 2019 03:36:49 -0400
Received: from [176.228.60.248] (port=1349 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1hZ9Qf-0001qB-7W; Fri, 07 Jun 2019 03:36:49 -0400
Date: Fri, 07 Jun 2019 07:36:00 -0000
Message-Id: <83h891rgmw.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: orgads@gmail.com
CC: gdb-patches@sourceware.org
In-reply-to: <20190607062719.10989-1-orgads@gmail.com>
Subject: Re: [PATCH] Fix cache dir resolving on Windows
References: <20190603193716.4861-1-orgads@gmail.com> <20190607062719.10989-1-orgads@gmail.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-IsSubscribed: yes
X-SW-Source: 2019-06/txt/msg00156.txt.bz2

> From: orgads@gmail.com
> Cc: Orgad Shaneh <orgads@gmail.com>
> Date: Fri,  7 Jun 2019 09:27:19 +0300
> 
> From: Orgad Shaneh <orgads@gmail.com>
> 
> ... when not running from MSYS environment, and HOME is not set.
> ---
>  gdb/common/pathstuff.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/gdb/common/pathstuff.c b/gdb/common/pathstuff.c
> index 2b1669a5b9..59410fb61f 100644
> --- a/gdb/common/pathstuff.c
> +++ b/gdb/common/pathstuff.c
> @@ -231,6 +231,10 @@ get_standard_cache_dir ()
>  #endif
>  
>    const char *home = getenv ("HOME");
> +#ifdef _WIN32
> +  if (home == nullptr)
> +      home = getenv ("APPDATA");
> +#endif
>    if (home != NULL)
>      {
>        /* Make sure the path is absolute and tilde-expanded.  */

Thanks, this LGTM.