[PATCH] Remove "\nError: " suffix from nat/fork-inferior.c:trace_start_error warning message

Sergio Durigan Junior
2019-08-30T19:51:08Z

Rationale: https://sourceware.org/ml/gdb-patches/2019-08/msg00651.html

This very simple patch removes the "\nError: " suffix from the warning
message printed by nat/fork-inferior.c:trace_start_error. This proved
to just pollute the screen, causing things like:

Starting program: /usr/bin/true
warning: Could not trace the inferior process.
Error:
warning: ptrace: Permission denied

This "Error: " string is not useful at all, and can confuse things,
therefore let's just remove it and simplify the resulting messages:

Starting program: /usr/bin/true
warning: Could not trace the inferior process.
warning: ptrace: Permission denied

2019-08-29 Sergio Durigan Junior <sergiodj@redhat.com>

* nat/fork-inferior.c (trace_start_error): Remove "\nError: "
suffix from warning message.
---
gdb/nat/fork-inferior.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/nat/fork-inferior.c b/gdb/nat/fork-inferior.c
index 68b51aa814..355e9bef43 100644
--- a/gdb/nat/fork-inferior.c
+++ b/gdb/nat/fork-inferior.c
@@ -580,7 +580,7 @@ trace_start_error (const char *fmt, ...)
va_list ap;

va_start (ap, fmt);
- warning ("Could not trace the inferior process.\nError: ");
+ warning ("Could not trace the inferior process.");
vwarning (fmt, ap);
va_end (ap);

--
2.21.0