From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121094 invoked by alias); 18 Dec 2019 18:45:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121074 invoked by uid 89); 18 Dec 2019 18:45:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=outweigh, enjoy X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Dec 2019 18:44:59 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48222) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iheJd-000494-JR; Wed, 18 Dec 2019 13:44:57 -0500 Received: from [176.228.60.248] (port=1491 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iheJc-0000KO-RC; Wed, 18 Dec 2019 13:44:57 -0500 Date: Wed, 18 Dec 2019 18:45:00 -0000 Message-Id: <83h81x323k.fsf@gnu.org> From: Eli Zaretskii To: Christian Biesinger CC: gdb-patches@sourceware.org In-reply-to: <20191218181413.128412-1-cbiesinger@google.com> (gdb-patches@sourceware.org) Subject: Re: [PATCH] Link to -lssp when available (fixes mingw build) References: <20191218181413.128412-1-cbiesinger@google.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00784.txt.bz2 > Date: Wed, 18 Dec 2019 12:14:13 -0600 > From: "Christian Biesinger via gdb-patches" > Cc: Christian Biesinger > > Recent mingw versions require -lssp when using _FORTIFY_SOURCE, which > gdb does (in common-defs.h) > https://github.com/msys2/MINGW-packages/issues/5868#issuecomment-544107564 > > gdb/ChangeLog: > > 2019-12-18 Christian Biesinger > > * configure: Regenerate. > * gdbsupport/common.m4: Look for -lssp to fix mingw. This will produce a GDB binary that requires libssp-0.dll to be present to run, won't it? And since libssp-0.dll is part of GCC, this will have 2 annoying effects: . we could be in "DLL hell" if there's an incompatibility between libssp against which GDB was linkes and the one actually installed on the system where we run GDB; . if someone wants to distribute MinGW binaries of GDB, they will have to distribute the GCC sources as well, since DLLs cannot enjoy the libgcc-type exception Is there a way to link against libssp.a statically? If so, it would be better to do that. Failing that, I'd recommend not to define _FORTIFY_SOURCE in MinGW builds, because the above annoyances IMO outweigh its utility. Thanks.