Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii via Gdb-patches <gdb-patches@sourceware.org>
To: Enze Li <lienze2010@hotmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Add new 'print nibbles' feature
Date: Thu, 10 Dec 2020 16:28:10 +0200	[thread overview]
Message-ID: <83h7ot4txh.fsf@gnu.org> (raw)
In-Reply-To: <MEAPR01MB3672CF2D4C7F5974E3A956B9DDCB0@MEAPR01MB3672.ausprd01.prod.outlook.com> (message from Enze Li via Gdb-patches on Thu, 10 Dec 2020 22:15:15 +0800)

> Date: Thu, 10 Dec 2020 22:15:15 +0800
> From: Enze Li via Gdb-patches <gdb-patches@sourceware.org>
> 
> gdb/doc/ChangeLog:
> 2020-12-10  Enze Li  <lienze2010@hotmail.com>
> 
> 	* gdb.texinfo: Document 'print nibbles'.

This should mention the node in which you made the chnanges (in
parentheses, as if the node were a function).

> +set print nibbles [on|off]
> +show print nibbles
> +  This controls whether the 'print/t' command will display the binary
> +  value in groups, and each group has four bits.  The default is 'off'.

This is fine, but let's please mention the word "nibbles" in this.
For example:

  show print nibbles
    This controls whether the 'print/t' command will display binary values
    in groups of four bits, known as "nibbles".  The default is 'off'.

> +@item -nibbles [@code{on}|@code{off}]
> +Set whether to print binary values in groups of four bits.
> +Related setting: @ref{set print nibbles}.

Likewise here.

> +@anchor{set print nibbles}
> +@item set print nibbles
> +@itemx set print nibbles on
> +Print binary values in groups of four bits when using the print command of
> +@value{GDBN} with the option @samp{/t}.  For example, this is what it
> +looks like with @code{set print nibbles on}:

And here.

Thanks.

      reply	other threads:[~2020-12-10 14:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10 14:15 Enze Li via Gdb-patches
2020-12-10 14:28 ` Eli Zaretskii via Gdb-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h7ot4txh.fsf@gnu.org \
    --to=gdb-patches@sourceware.org \
    --cc=eliz@gnu.org \
    --cc=lienze2010@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox