Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii via Gdb-patches <gdb-patches@sourceware.org>
To: Luis Machado <luis.machado@arm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH,v2 17/17] [gdb/docs] sme: Document SME registers and features
Date: Thu, 13 Apr 2023 20:45:04 +0300	[thread overview]
Message-ID: <83h6tj4qxr.fsf@gnu.org> (raw)
In-Reply-To: <56b69866-8f70-3bed-0645-79dcc4a99f23@arm.com> (message from Luis Machado on Thu, 13 Apr 2023 17:34:17 +0100)

> Date: Thu, 13 Apr 2023 17:34:17 +0100
> Cc: gdb-patches@sourceware.org
> From: Luis Machado <luis.machado@arm.com>
> 
> I may have made a few mistakes before using lower case svq and svl, which should now be
> fixed in the upcoming version. Before I send an update though, I'd like to clarify
> the terminology and how I'm using it. Just a sanity check that it isn't confusing still.
> 
> SVG, SVQ and SVL (upper case) are only definitions for SME. SVL is the vector size in bytes,
> SVG is SVL / 8 and SVQ is SVL / 16. All of them are vector sizes, but with different
> granularities.
> 
> GDB exposes the SME vector size SVG as the svg (lower case) register, so users can check the
> current vector size and change it if they want.
> 
> In the end, we have 3 definitions and a register.
> 
> Does that make sense?

I understand the terminology you want to use.

> > My main point was that it is easier and clearer to say ABCxABC than to
> > use some unrelated symbol N and then explain that N equals to the
> > parameter ABC.  But it's a minor issue.
> > 
> 
> That's fair. I find that slightly confusing too. What we should say, based on the
> SME vector size definitions above is:
> 
> The @code{za} register is a 2-dimensional square
> @code{@var{SVL}x@var{SVL}} matrix of bytes.
> 
> That makes it clear and obvious (to me) that we have a matrix of size
> SVL x SVL bytes.

Yes, but please note that the argument of @var should a lower-case
word.  In Info format, it is up-cases, but in HTML and PDF it's
typeset in slant typeface, and not up-cased.

This is actually one place where using SVL and SVG as parameters gets
in the way: you spell them in upper-case, which is against the
practice of using @var.

> > Then please say that without using the word "same" on its own.  "Same"
> > begs the question "same as what?", which doesn't have an answer in
> > this context.
> >
> 
> Ok. I think something like the following might address your concerns?
> 
> Attempting to set the @code{svg} register value to its current value will have no effect.

Yes, this is okay.

Thanks.

  reply	other threads:[~2023-04-13 17:44 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-11  4:26 [PATCH 00/17] SME support for AArch64 gdb/gdbserver on Linux Luis Machado via Gdb-patches
2023-04-11  4:26 ` [PATCH 01/17] [gdb/aarch64] Fix register fetch/store order for native AArch64 Linux Luis Machado via Gdb-patches
2023-04-11  4:26 ` [PATCH 02/17] [gdb/aarch64] refactor: Rename SVE-specific files Luis Machado via Gdb-patches
2023-04-11  4:26 ` [PATCH 03/17] [gdb/gdbserver] refactor: Simplify SVE interface to read/write registers Luis Machado via Gdb-patches
2023-04-11  4:26 ` [PATCH 04/17] [gdb/aarch64] sve: Fix return command when using V registers in a SVE-enabled target Luis Machado via Gdb-patches
2023-04-11  4:26 ` [PATCH 05/17] [gdb/aarch64] sme: Enable SME registers and pseudo-registers Luis Machado via Gdb-patches
2023-04-11  4:26 ` [PATCH 06/17] [gdbserver/aarch64] refactor: Adjust expedited registers dynamically Luis Machado via Gdb-patches
2023-04-11  4:26 ` [PATCH 07/17] [gdbserver/aarch64] sme: Add support for SME Luis Machado via Gdb-patches
2023-04-11  4:26 ` [PATCH 08/17] [gdb/aarch64] sve: Fix signal frame z/v register restore Luis Machado via Gdb-patches
2023-04-11  4:26 ` [PATCH 09/17] [gdb/aarch64] sme: Signal frame support Luis Machado via Gdb-patches
2023-04-11  4:26 ` [PATCH 10/17] [gdb/aarch64] sme: Fixup sigframe gdbarch when vg/svg changes Luis Machado via Gdb-patches
2023-04-11  4:26 ` [PATCH 11/17] [gdb/aarch64] sme: Support TPIDR2 signal frame context Luis Machado via Gdb-patches
2023-04-11  4:26 ` [PATCH 12/17] [binutils/aarch64] sme: Core file support Luis Machado via Gdb-patches
2023-04-11  4:26 ` [PATCH 13/17] [gdb/generic] corefile/bug: Use thread-specific gdbarch when dumping register state to core files Luis Machado via Gdb-patches
2023-04-11  4:26 ` [PATCH 14/17] [gdb/generic] corefile/bug: Fixup (gcore) core file target description reading order Luis Machado via Gdb-patches
2023-04-11  4:26 ` [PATCH 15/17] [gdb/aarch64] sme: Core file support for Linux Luis Machado via Gdb-patches
2023-04-11  4:26 ` [PATCH 16/17] [gdb/testsuite] sme: Add SVE/SME testcases Luis Machado via Gdb-patches
2023-04-11  4:26 ` [PATCH 17/17] [gdb/docs] sme: Document SME registers and features Luis Machado via Gdb-patches
2023-04-11  7:09   ` Eli Zaretskii via Gdb-patches
2023-04-11  7:22     ` Luis Machado via Gdb-patches
2023-04-12 12:04   ` [PATCH,v2 " Luis Machado via Gdb-patches
2023-04-13  7:57     ` [PATCH, v2 " Eli Zaretskii via Gdb-patches
2023-04-13 12:17       ` [PATCH,v2 " Luis Machado via Gdb-patches
     [not found]         ` <83leiv4xsc.fsf@gnu.org>
2023-04-13 16:34           ` Luis Machado via Gdb-patches
2023-04-13 17:45             ` Eli Zaretskii via Gdb-patches [this message]
2023-04-17 17:19   ` [PATCH,v3 " Luis Machado via Gdb-patches
2023-04-22  9:21     ` [PATCH, v3 " Eli Zaretskii via Gdb-patches
2023-04-26 15:00       ` [PATCH,v3 " Luis Machado via Gdb-patches
2023-04-26 16:11         ` Eli Zaretskii via Gdb-patches
     [not found]           ` <11f9bfb1-78cb-80db-fbc6-3262f0f9fdae@arm.com>
2023-04-27  9:10             ` Eli Zaretskii via Gdb-patches
2023-04-27  9:12               ` Luis Machado via Gdb-patches
2023-04-11 15:50 ` [PATCH 00/17] SME support for AArch64 gdb/gdbserver on Linux John Baldwin
2023-04-12  8:47   ` Willgerodt, Felix via Gdb-patches
2023-04-12  9:12   ` Luis Machado via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h6tj4qxr.fsf@gnu.org \
    --to=gdb-patches@sourceware.org \
    --cc=eliz@gnu.org \
    --cc=luis.machado@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox