From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-64969-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28932 invoked by alias); 30 Jun 2009 03:06:08 -0000
Received: (qmail 28924 invoked by uid 22791); 30 Jun 2009 03:06:07 -0000
X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout2.012.net.il (HELO mtaout2.012.net.il) (84.95.2.4)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Jun 2009 03:05:58 +0000
Received: from conversion-daemon.i_mtaout2.012.net.il by i_mtaout2.012.net.il (HyperSendmail v2004.12) id <0KM100D0078JGK00@i_mtaout2.012.net.il> for gdb-patches@sourceware.org; Tue, 30 Jun 2009 06:05:55 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([84.229.213.34]) by i_mtaout2.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KM100C4H79U4E40@i_mtaout2.012.net.il>; Tue, 30 Jun 2009 06:05:55 +0300 (IDT)
Date: Tue, 30 Jun 2009 03:06:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] Conditional tracepoints
In-reply-to: <4A492432.8010600@codesourcery.com>
To: Stan Shebs <stan@codesourcery.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83fxdi4e0c.fsf@gnu.org>
References: <4A45AE9B.9020400@codesourcery.com> <83fxdlzvin.fsf@gnu.org> <4A492432.8010600@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-06/txt/msg00856.txt.bz2

> Date: Mon, 29 Jun 2009 13:29:38 -0700
> From: Stan Shebs <stan@codesourcery.com>
> CC: Stan Shebs <stan@codesourcery.com>, gdb-patches@sourceware.org
> 
> >> ! (@pxref{Agent Expressions}).  The @samp{agent} version produces an
> >> ! expression useful for data collection, such as by tracepoints, while
> >> ! @samp{maint agent-eval} produces an expression that evaluates directly
> >> ! to a result.
> >>     
> >
> > I must admit that I don't understand the description you added.  What
> > does "expression useful for data collection" mean, and how is it
> > different from "expression that evaluates directly to a result"?
> >   
> Expressions compiled for tracing have bytecodes that cause saving of the 
> blocks of memory etc that would be needed back on the host to evaluate 
> the expression at some later date.  It occurs to me that the Agent 
> Expressions section should say a little more about the two kind of 
> expressions.

Fine with me; in that case, this text should use the same terminology
as "Agent Expressions" and perhaps have a cross-reference to there.

> >> + @item ConditionalTracepoints
> >> + The remote stub accepts and tests conditional expressions defined for
> >> + tracepoints (@pxref{Tracepoint Conditions}).
> >>     
> >
> > Don't you mean "accepts and supports" or "accepts and implements"?
> >   
> "support" and "implement" seemed overused. :-)

They are still more descriptive than "tests" in this context, IMO.

Thanks.