From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15670 invoked by alias); 11 Aug 2010 18:00:27 -0000 Received: (qmail 15657 invoked by uid 22791); 11 Aug 2010 18:00:26 -0000 X-SWARE-Spam-Status: No, hits=-0.0 required=5.0 tests=AWL,BAYES_05,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Aug 2010 18:00:20 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0L7000C001WCVU00@a-mtaout22.012.net.il> for gdb-patches@sources.redhat.com; Wed, 11 Aug 2010 21:00:17 +0300 (IDT) Received: from HOME-C4E4A596F7 ([77.126.102.143]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L7000B0420GF5M0@a-mtaout22.012.net.il>; Wed, 11 Aug 2010 21:00:17 +0300 (IDT) Date: Wed, 11 Aug 2010 18:00:00 -0000 From: Eli Zaretskii Subject: Re: Better MI memory commands In-reply-to: <201008111637.49621.vladimir@codesourcery.com> To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Reply-to: Eli Zaretskii Message-id: <83fwyluj0q.fsf@gnu.org> References: <201006251232.55281.vladimir@codesourcery.com> <837hlndrni.fsf@gnu.org> <201008111637.49621.vladimir@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00149.txt.bz2 > From: Vladimir Prus > Date: Wed, 11 Aug 2010 16:37:49 +0400 > Cc: gdb-patches@sources.redhat.com > > > > +The output of the command has a result record named @samp{memory}, > > ^^^^^^^^^^^^^^^^^^^ > > Perhaps "is a result record"? > > Nope. "result record" is actually a nonterminal in MI grammar, and output > of a command may have result records but is never a result record itself. > > > And what is the importance of naming > > this record `memory'? why is the name important here? > > Because for frontend to access a result record in a command output, it > has to know its name. Then perhaps The result record (@pxref{GDB/MI Result Records}) that is output of the command includes a field named @samp{memory} whose content is a list of tuples ... > > > +@item contents > > > +The contents of the memory block, as hex-encoded string of bytes. > > > > But your example shows this: > > > > > + contents="01000000020000000300"@}] > > > > This doesn't look like a ``string of bytes'' to me. Or maybe I don't > > understand what you meant by that? > > It seems very much like a hex-encoded string of bytes. Maybe, "hex-encoded > sequence of bytes" will work better? I suggest just The contents of the memory block, in hex. > > > +@item @var{contents} > > > +The hex-encoded bytes to write. The size of this parameter determines > > > +how many bytes should be written.^^^^^^^^ > > > > You probably meant "the value", not "the size". > > Actually, "the size". A parameter is a string, a string has a size A string has a length, not size, so please use that. Actually, perhaps this sentence should be simply removed, as it seems to say something trivial, doesn't it? > What about the attached revision? Okay, with the above changes and two more comments: > +This command attempts to read all accessible memory regions in the > +specified range. First, all regions marked as unreadable in the memory > +map (if one is defined) will be skipped. ^^^^^^^^^^^^^^^^^^^^^^^ I asked for a cross-reference here to where memory maps are described. > +At present, if multiple What happened here?