Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: fix PR python/11915
Date: Mon, 23 Aug 2010 17:16:00 -0000	[thread overview]
Message-ID: <83fwy5nt7w.fsf@gnu.org> (raw)
In-Reply-To: <m3iq31qn19.fsf@fleche.redhat.com>

> From: Tom Tromey <tromey@redhat.com>
> Cc: gdb-patches@sourceware.org
> Date: Mon, 23 Aug 2010 11:03:30 -0600
> 
> >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
> 
> Eli> "Inclusive upper bound"?  Does this mean that if the argument is N,
> Eli> then the array will have N+1 members, from zero to N?  That sounds
> Eli> against the intuition, doesn't it?
> 
> Yes, but it is the only way to allow an array whose upper bound is
> MAXINT.  I think it is also consistent with Type.range.

It means I'd need to use an argument of zero to have an array of one
element.  It also means the size of an array whose upper bound is
MAXINT is MAXINT+1, which could overflow, no?

I'm fine with this if users will be, but it feels strange.

> >> +given, the first argument is the lower bound of the array, and the
> >> +second argument is the upper bound of the array.
> 
> Eli> Will the reader know whether negative arguments are allowed (provided
> Eli> that the second is greater than the first)?  Or is it a good idea to
> Eli> tell explicitly?
> 
> I added a note.  New patch appended.

Thanks, this version is fine with me.


      reply	other threads:[~2010-08-23 17:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-20 22:32 Tom Tromey
2010-08-21  7:54 ` Eli Zaretskii
2010-08-23 17:03   ` Tom Tromey
2010-08-23 17:16     ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fwy5nt7w.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox