From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-77928-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22460 invoked by alias); 31 Jan 2011 20:09:18 -0000
Received: (qmail 22336 invoked by uid 22791); 31 Jan 2011 20:09:12 -0000
X-SWARE-Spam-Status: No, hits=-0.5 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 31 Jan 2011 20:09:06 +0000
Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LFW00A00KFQW000@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Mon, 31 Jan 2011 22:09:03 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.124.97.124]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LFW00AG9LB2MB70@a-mtaout23.012.net.il>; Mon, 31 Jan 2011 22:09:03 +0200 (IST)
Date: Mon, 31 Jan 2011 20:39:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA] Implement support for PowerPC BookE ranged breakpoints
In-reply-to: <1296500344.3120.10.camel@hactar>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83fws8g7j3.fsf@gnu.org>
References: <1296177985.2843.82.camel@hactar> <83bp31idgm.fsf@gnu.org> <1296500344.3120.10.camel@hactar>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-01/txt/msg00596.txt.bz2

> From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> Cc: gdb-patches@sourceware.org
> Date: Mon, 31 Jan 2011 16:59:04 -0200
> 
> > > +  a Linux kernel version 2.6.34 or later, GDB supports ranged breakpoints,
> > > +  which stop execution of the inferior whenever it executes any address
> > > +  within the specified range.  See the "PowerPC Embedded" section in the
> > 
> > "whenever it executes an instruction at any address within the
> > specified range".  (You cannot "execute" an address.)
> 
> It was an analogy with "read an address" and "write an address", but I
> guess even those expressions are not that good. :-) Fixed.

"Read from an address" and "write to an address" would be better, yes.

> > > +      sals_start.sals = (struct symtab_and_line *)
> > > +	xmalloc (sizeof (struct symtab_and_line));
> > > +      sals_start.nelts = 1;
> > 
> > Spaces and TABs mixup alert!
> 
> Hum, I couldn't find the mixup. the lines above and below xmalloc need
> to use spaces because they start at column 7. The xmalloc line uses TAB
> since it starts at column 9 (and it doesn't have any spaces only one
> TAB).

Then it's my mixup, sorry.  Disregard that comment.