From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79387-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8050 invoked by alias); 7 Mar 2011 20:26:14 -0000
Received: (qmail 7863 invoked by uid 22791); 7 Mar 2011 20:26:14 -0000
X-SWARE-Spam-Status: No, hits=-0.4 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_WEB,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Mar 2011 20:26:03 +0000
Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LHP00K00FEK5700@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Mon, 07 Mar 2011 22:26:01 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.124.58.59]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LHP00K6EFFB4A20@a-mtaout23.012.net.il>; Mon, 07 Mar 2011 22:26:01 +0200 (IST)
Date: Mon, 07 Mar 2011 20:28:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch] Implement set/show callback functions in gdb.Parameter
In-reply-to: <m34o7ehqht.fsf@redhat.com>
To: pmuldoon@redhat.com
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83fwqyhe6y.fsf@gnu.org>
References: <m3bp2dw9io.fsf@redhat.com> <m3d3mc80js.fsf@fleche.redhat.com> <m34o7ehqht.fsf@redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00500.txt.bz2

> From: Phil Muldoon <pmuldoon@redhat.com>
> Cc: gdb-patches@sourceware.org
> Date: Mon, 07 Mar 2011 15:58:22 +0000
> 
> 
> +@defop Operation {parameter} get_set_string self
> +@value{GDBN} will call this method when a parameter has been
> +invoked via the @code{set} API (for example, @kbd{set foo off}).  The

Calling an operation a "parameter" is not the best idea.  Already you
need to talk about "invoking a parameter", which sounds awkward.  Can
we find a better word here?

> +@defop Operation {parameter} get_show_string self, svalue

Is the comma really necessary here?

Otherwise, okay.

Thanks.