From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10196 invoked by alias); 15 Nov 2011 16:57:06 -0000 Received: (qmail 10183 invoked by uid 22791); 15 Nov 2011 16:57:03 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Nov 2011 16:56:47 +0000 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LUP00E00OAY2N00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Tue, 15 Nov 2011 18:56:45 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.184.15]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LUP00EP6OEK0Q40@a-mtaout21.012.net.il>; Tue, 15 Nov 2011 18:56:45 +0200 (IST) Date: Tue, 15 Nov 2011 16:57:00 -0000 From: Eli Zaretskii Subject: Re: RFA: documentation change for ambiguous linespec patch In-reply-to: To: Tom Tromey Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83fwhpe36s.fsf@gnu.org> References: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00387.txt.bz2 > From: Tom Tromey > Date: Mon, 14 Nov 2011 14:16:22 -0700 > > To my surprise, the ambiguous linespec change mostly makes gdb accord > better with the existing documentation. So, I did not need many changes > to the documentation. > > Here is what I propose. Thanks. > +* GDB now handles ambiguous linespecs more consistently; the existing > + FILE:LINE support has been expanded to other types of linespecs. A > + breakpoint will now have locations at all the matching points in all How about "...will now be set on all matching locations..."? "Have locations" sounds a bit confusing; at least I never thought of a breakpoint as _having_ a location. > + locations will be added or subtracted according to > + inferior changes. Will these additions and removals be announced by GDB? If so, perhaps an example or a note to that effect is in order. Also, is "subtracted" the right word here? I use it only as an arithmetic operation, but I'm not a native speaker. The rest is (trivially) fine with me. Thanks.