From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13660 invoked by alias); 14 Mar 2012 17:40:31 -0000 Received: (qmail 13650 invoked by uid 22791); 14 Mar 2012 17:40:30 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Mar 2012 17:40:16 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M0V00400Y99PL00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Wed, 14 Mar 2012 19:40:14 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.179.236]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M0V0031MYEZYGG0@a-mtaout22.012.net.il>; Wed, 14 Mar 2012 19:40:13 +0200 (IST) Date: Wed, 14 Mar 2012 17:40:00 -0000 From: Eli Zaretskii Subject: Re: [patch] GDB 7.2: new feature for "backtrace" that cuts path to file (remain filename) In-reply-to: To: iam ahal Cc: tromey@redhat.com, pedro@codesourcery.com, dje@google.com, gdb-patches@sourceware.org, pmuldoon@redhat.com, brobecker@adacore.com, drow@false.org, jan.kratochvil@redhat.com Reply-to: Eli Zaretskii Message-id: <83fwdbw077.fsf@gnu.org> References: <83fwgzbrp9.fsf@gnu.org> <201112061249.47758.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00491.txt.bz2 > Date: Sat, 10 Mar 2012 23:14:43 +0300 > From: iam ahal > Cc: Tom Tromey , pedro@codesourcery.com, dje@google.com, gdb-patches@sourceware.org, pmuldoon@redhat.com, brobecker@adacore.com, drow@false.org, jan.kratochvil@redhat.com > > I've tried carefully to fix documentation and a little piece of code. > Also, I've added NEWS entry. Thanks! > +If backtraces isn't easy to read due to a long absolute filename path recorded and Just "filename record", please. GNU Coding Standards frown on using "path" for anything but PATH-style lists of directories. > +you just want to see only a basename or a relative filename path, you can change this ^^^^ Same here: just "relative filename". > +Display a filename recorded at the compilation time. This is the default. ^^^ Please remove "the", it's not needed here. Also, I would say "exactly as recorded at compile time". I think this is more clear. > +@item set backtrace filename-display relative > +Display a filename without the compilation directory part. This is unclear. What does it mean, exactly? that the filename is displayed relative to the compilation directory? Can you give me an example? I will then suggest an alternative wording to make your intent more clear. > + add_setshow_enum_cmd ("filename-display", class_obscure, > + filename_display_kind_names, > + &filename_display_string, _("\ > +Set how to display filename in backtraces."), _("\ > +Show how to display filename in backtraces."), _("\ I think "filenames", in plural, is better here. > * New options > > set backtrace filename-display as-recorded|basename|relative > show backtrace filename-display > Control a way in which a filename is displayed in backtraces. ^^^^^ ^^^^^^^^^^ "the way" and "filenames" (plural and without "a"). OK with those changes.