Re: [PATCH v3 19/19] btrace: honour scheduler-locking for all-stop targets

Pedro Alves
2015-09-18T11:39:53Z

On 09/17/2015 03:09 PM, Markus Metzger wrote:
> +foreach schedlock { "replay" "on" } {
> + with_test_prefix "schedlock-$schedlock" {
> + gdb_test_no_output "set scheduler-locking $schedlock"
> +
> + test_navigate
> + test_step
> + test_cont
> + test_rstep
> + test_goto_end
> + }
> }
>

Indenting here looks odd compared to the rest of the file.

I'd merge in the "step" case too, like:

foreach schedlock { "replay" "on" "step" } {
with_test_prefix "schedlock-$schedlock" {
gdb_test_no_output "set scheduler-locking $schedlock"

test_navigate
test_step
if {$schedlock == "step"} {
test_cont_all
} else {
test_cont
}
test_rstep
test_goto_end
}
}

Otherwise looks fine to me.

Thanks,
Pedro Alves