From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-126472-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2782 invoked by alias); 5 Oct 2015 12:26:56 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 2770 invoked by uid 89); 5 Oct 2015 12:26:55 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout26.012.net.il
Received: from mtaout26.012.net.il (HELO mtaout26.012.net.il) (80.179.55.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Oct 2015 12:26:54 +0000
Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0NVQ00G00YIAKW00@mtaout26.012.net.il> for gdb-patches@sourceware.org; Mon, 05 Oct 2015 15:29:46 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NVQ007EYYPMNC90@mtaout26.012.net.il>; Mon, 05 Oct 2015 15:29:46 +0300 (IDT)
Date: Mon, 05 Oct 2015 12:26:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 4/4] GDB/MI: inferior standard I/O redirection
In-reply-to: <1444045617-14526-5-git-send-email-crosa@redhat.com>
To: Cleber Rosa <crosa@redhat.com>
Cc: gdb-patches@sourceware.org, areis@redhat.com, palves@redhat.com, crosa@redhat.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83fv1pzek4.fsf@gnu.org>
References: <1444045617-14526-1-git-send-email-crosa@redhat.com> <1444045617-14526-5-git-send-email-crosa@redhat.com>
X-IsSubscribed: yes
X-SW-Source: 2015-10/txt/msg00036.txt.bz2

> From: Cleber Rosa <crosa@redhat.com>
> Cc: areis@redhat.com, palves@redhat.com, Cleber Rosa <crosa@redhat.com>
> Date: Mon,  5 Oct 2015 08:46:57 -0300
> 
> This introduces the following MI commands:
> 
>  * -inferior-stdin-set
>  * -inferior-stdin-show
>  * -inferior-stdout-set
>  * -inferior-stdout-show
>  * -inferior-stderr-set
>  * -inferior-stderr-show
> 
> Which are the MI version of the inferior standard I/O redirection
> commands:
> 
>  * set inferior-stdin (aliased as stdin)
>  * show inferior-stdin
>  * set inferior-stdout (aliased as stdout)
>  * show inferior-stdout
>  * set inferior-stderr (aliased as stderr)

Thanks.

> gdb/doc/ChangeLog:
>     2015-10-05  Cleber Rosa  <crosa@redhat.com>
> 
>     * gdb.texinfo (info): Add documentation about the
>     -inferior-stdin-set, inferior-stdin-show, -inferior-stdout-set,
>     inferior-stdout-show, -inferior-stderr-set, inferior-stderr-show
>     commands.

I think these new MI commands should be mentioned in NEWS as well.

> +The corresponding @value{GDBN} command is @samp{set inferior-stdin} /tmp/answers.

I believe we use @code as markup for command names, not @samp.

Otherwise, the documentation part is OK.