From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29044 invoked by alias); 22 Jun 2017 19:42:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28992 invoked by uid 89); 22 Jun 2017 19:42:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Jun 2017 19:42:12 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dO7zT-0006UB-F7 for gdb-patches@sourceware.org; Thu, 22 Jun 2017 15:42:10 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50277) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dO7zT-0006U5-C1; Thu, 22 Jun 2017 15:42:07 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4319 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dO7zQ-0004qD-K5; Thu, 22 Jun 2017 15:42:07 -0400 Date: Thu, 22 Jun 2017 19:42:00 -0000 Message-Id: <83fuervmh1.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: gdb-patches@sourceware.org In-reply-to: <77ada869-54e0-6fbd-3edd-9a0000cd1aaf@redhat.com> (message from Pedro Alves on Wed, 21 Jun 2017 16:50:24 +0100) Subject: Re: [PATCH 40/40] Document breakpoints / linespec & co improvements (manual + NEWS) Reply-to: Eli Zaretskii References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-41-git-send-email-palves@redhat.com> <83a85qczmo.fsf@gnu.org> <77ada869-54e0-6fbd-3edd-9a0000cd1aaf@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00662.txt.bz2 > Cc: gdb-patches@sourceware.org > From: Pedro Alves > Date: Wed, 21 Jun 2017 16:50:24 +0100 > > +A likely situation where you might need this is in typing an > +expression that involves a C@t{++} symbol name with template > +parameters. This is because when completing expressions, GDB treats ^^^ @value{GDBN} > +See @ref{quoting names} for a description of other scenarios that ^^^^^^^^ This is OK, but @xref does the same job. In any case, it is good practice to put a comma after the closing brace, or else some versions of makeinfo will bitch at you. > +For example, assuming a program with symbols named @code{A::B::func} > +and @code{B::func}, both commands @code{break -function func} and > +@code{break -function B::func} set a breakpoint on both symbols. > + > +@item -qualified @var{function} > +Like @code{-function}, but the value specifies a fully qualified name > +of a function. > + > +For example, assuming a C@t{++} program with symbols named Two "For example" too close to one another. Suggest to replace the 2nd one with "As another example". > +@code{A::B::func} and @code{B::func}, the @code{break -qualified > +B::func} command ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ This is better put in @w{..}. > + > @item -label @var{label} > The value specifies the name of a label. When the function > name is not specified, the label is searched in the function of the currently > @@ -14992,6 +15035,49 @@ the same notation that is used to declare such symbols in C@t{++}: type > also use the @value{GDBN} command-line word completion facilities to list the > available choices, or to finish the type list for you. > @xref{Completion,, Command Completion}, for details on how to do this. > + > +@item @r{Breakpoints in functions with ABI tags} > + > +The GNU C@t{++} compiler introduced the notion of ABI ``tags'', which "tags" should be in @dfn (which will produce the quotes, so you can lose them). Also, I'd add a @cindex entry here about "ABI tags". > +when compiled for the C++11 ABI is marked with the @code{cxx11} ABI ^^^^^ C@t{++}11, I think. > +tag, and @value{GDBN} displays the symbol like this: > + > +@smallexample > +function[abi:cxx11](int) > +@end smallexample Where does GDB use this format? Only in "info break", as shown below, or also in other contexts? If the latter, I suggest that the above example show some full output with context. The patch is OK with those fixed. Thanks.