Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] (try to) consistently use 'frame level' concept instead of 'frame number'.
Date: Fri, 13 Jul 2018 06:52:00 -0000	[thread overview]
Message-ID: <83fu0neifl.fsf@gnu.org> (raw)
In-Reply-To: <20180712221536.26845-1-philippe.waroquiers@skynet.be> (message	from Philippe Waroquiers on Fri, 13 Jul 2018 00:15:36 +0200)

> From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> Date: Fri, 13 Jul 2018 00:15:36 +0200
> 
> Following the discussion in the 'frame apply' patch and the patch proposed
> in https://sourceware.org/ml/gdb-patches/2018-06/msg00170.html
> the idea is rather to speak about 'frame level' to identify a frame,
> rather than 'frame number'.

I question the wisdom of changing such veteran terminology.

> -@cindex frame number
> -@value{GDBN} assigns numbers to all existing stack frames, starting with
> +@cindex frame level
> +In @value{GDBN}, each existing stack frame has a level, starting with
>  zero for the innermost frame, one for the frame that called it,
> -and so on upward.  These numbers do not really exist in your program;
> -they are assigned by @value{GDBN} to give you a way of designating stack
> +and so on upward.  These levels give you a way of designating stack
>  frames in @value{GDBN} commands.

If we are going to make this change, then I would suggest to keep the
index entry, _add_ to it an entry about "frame level", and explain
here what that level is, something like this:

  @value{GDBN} labels each existing stack frame with a @dfn{level}, a
  number that is zero for the innermost frame, one for the frame that
  called it, and so on upward.  These level numbers give you a way of
  designating stack frames in @value{GDBN} commands.

> -it had a separate frame, which is numbered zero as usual, allowing
> +it had a separate frame, which has a level zero as usual, allowing
                                        ^^^^^^^^^^
"level of zero".

> -Select frame number @var{n}.  Recall that frame zero is the innermost
> +Select frame level @var{n}.  Recall that frame zero is the innermost
   ^^^^^^^^^^^^^^^^^^^^^^^^^^
"Select frame whose level is @var{n}."

Thanks.


  reply	other threads:[~2018-07-13  6:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-12 22:15 Philippe Waroquiers
2018-07-13  6:52 ` Eli Zaretskii [this message]
2018-07-13  7:23   ` Philippe Waroquiers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fu0neifl.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=philippe.waroquiers@skynet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox