From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126123 invoked by alias); 23 May 2019 04:31:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126115 invoked by uid 89); 23 May 2019 04:31:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 May 2019 04:31:33 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53247) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTfO7-0006Yj-Ka; Thu, 23 May 2019 00:31:31 -0400 Received: from [176.228.60.248] (port=2535 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hTfO6-0002b6-LI; Thu, 23 May 2019 00:31:31 -0400 Date: Thu, 23 May 2019 04:31:00 -0000 Message-Id: <83ftp57pw4.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: gdb-patches@sourceware.org In-reply-to: <20190522205327.2568-25-palves@redhat.com> (message from Pedro Alves on Wed, 22 May 2019 21:53:27 +0100) Subject: Re: [PATCH 24/24] NEWS and manual changes for command options changes References: <20190522205327.2568-1-palves@redhat.com> <20190522205327.2568-25-palves@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00531.txt.bz2 > From: Pedro Alves > Date: Wed, 22 May 2019 21:53:27 +0100 > > gdb/ChangeLog: > yyyy-mm-dd Pedro Alves > > * NEWS (New commands): Mention "maint test-options > require-delimiter", "maint test-options unknown-is-error", "maint > test-options unknown-is-operand" and "maint show > test-options-completion-result". > (New command options, command completion): New section. > (Completion improvements): New section. > Mention that you can abbreviate "unlimited". > > gdb/doc/ChangeLog: > yyyy-mm-dd Pedro Alves > > * gdb.texinfo (Command Completion): Mention command options too. > (Command Options): New node. > (Threads): Add anchors. Extend descriptions of the "taas" and > "tfaas" commands. > (Backtrace): Describe new options of the "backtrace" command. Add > anchors. > (Frame Apply): Describe new options of the "frame apply" and > "faas" commands. Add anchors. > (Data): Describe new options of the "print" command. Add anchors. > (Compiling and Injecting Code): Mention options of the "compile > print" command. > (Maintenance Commands): Mention "maint test-options" subcommands > and the "maint show test-options-completion-result" command. Thanks. A couple of minor comments. > +apply all} command. See @ref{thread apply all}. I'd prefer @xref to "See @ref" at the beginning of a sentence. > +apply} command. See @ref{frame apply}. Same here. > +@item -past-main [@code{on}|@code{off}] > +Set whether backtraces should continue past "main". Related setting: "main" is a symbol, so please use @code{main}. > +@item -entry-values @code{no}|@code{only}|@code{preferred}|@code{if-needed}|@code{both}|@code{compact}|@code{default} Does this long line look reasonable in print? If not, perhaps using just one meta-argument, followed by a table of possible values, would be better? > +@item -past-main [@code{on}|@code{off}] > +Whether backtraces should continue past "main". Same issue with "main". > +apply} command. See @ref{frame apply}. "See @ref" again. > +@item -object [@code{on}|@code{off}] > +Set printing C++ virtual function tables. Related setting: @ref{set ^^^ C@t{++}, please (here and elsewhere in the patch). > +@item -repeats @var{number-of-repeats}|@code{unlimited} > +Set threshold for repeated print elements. "unlimited" causes all ^^ Two spaces between sentences. Also, "unlimited" at the sentence beginning looks awkward without capitalization. Thanks.