From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oGfqHER4tmOVwA8AWB0awg (envelope-from ) for ; Thu, 05 Jan 2023 02:12:04 -0500 Received: by simark.ca (Postfix, from userid 112) id 723341E222; Thu, 5 Jan 2023 02:12:04 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=r01A3/it; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 253EF1E110 for ; Thu, 5 Jan 2023 02:12:04 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 427D43858C39 for ; Thu, 5 Jan 2023 07:12:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 427D43858C39 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1672902723; bh=yk8Mxl2Cz6RBjsF5i4SYWYZzhA8j+9AMM8qEITkKdRA=; h=Date:To:Cc:In-Reply-To:Subject:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=r01A3/itDxKQERjXS6QN1NdkKDbB82m+MG3v6WYl8YeO6Z0vZDfBhkHpUKaKxdVKX Cuoji57k5z9gHtJu1yIsDlqAB+Y5KTnveHF3xDhMccKVfR4H/wtWg0xIS/SY/EjlsK xQKHQUN5N2m66IAFNCkdElOaNYxdlTgoJA1jS3w4= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 804D13858D35 for ; Thu, 5 Jan 2023 07:11:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 804D13858D35 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDKPc-0000K7-T3; Thu, 05 Jan 2023 02:11:40 -0500 Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDKPc-0002sD-2u; Thu, 05 Jan 2023 02:11:40 -0500 Date: Thu, 05 Jan 2023 09:11:53 +0200 Message-Id: <83fscpxxom.fsf@gnu.org> To: Tom Tromey Cc: simark@simark.ca, cbiesinger@google.com, gdb-patches@sourceware.org, luis.machado@arm.com In-Reply-To: <878rii9bg3.fsf@tromey.com> (message from Tom Tromey on Wed, 04 Jan 2023 15:33:48 -0700) Subject: Re: Two observations using GDB 13 snapshot References: <83h6xugc5v.fsf@gnu.org> <835ye7e9jw.fsf@gnu.org> <87h6xrks77.fsf@tromey.com> <83mt7idacj.fsf@gnu.org> <87fsd4elb2.fsf@tromey.com> <83o7rs4qmg.fsf@gnu.org> <87cz84dasj.fsf@tromey.com> <835ydw20bw.fsf@gnu.org> <87wn6bbi5m.fsf@tromey.com> <83sfgz8m9i.fsf@gnu.org> <87o7rnb0ya.fsf@tromey.com> <83a6368chf.fsf@gnu.org> <87k02aaxc8.fsf@tromey.com> <83wn6a6n21.fsf@gnu.org> <587b899f-0f93-530a-7313-d4e1f9e501b9@simark.ca> <835ydt6jzw.fsf@gnu.org> <83wn63z81w.fsf@gnu.org> <46d7fd4b-d5f0-0007-3e88-20345e0e0584@simark.ca> <831qoayxuu.fsf@gnu.org> <878rii9bg3.fsf@tromey.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > From: Tom Tromey > Cc: Simon Marchi , cbiesinger@google.com, > tom@tromey.com, gdb-patches@sourceware.org, luis.machado@arm.com > Date: Wed, 04 Jan 2023 15:33:48 -0700 > > >>>>> "Eli" == Eli Zaretskii writes: > > Eli> Looks like indeed strcasecmp is the culprit. With the patch below, > Eli> which replaces strcasecmp with a simple case-insensitive comparison > Eli> that only works with ASCII, the phase of reading symbols from gdb.exe > Eli> goes down to just 6 seconds, which is basically the same time as with > Eli> GDB 12. > > Thank you. Hopefully the other patch I have pending, which does > something similar, should have the same effect. Thanks, I applied that patch (modulo the testsuite parts), and I can confirm that it is almost as fast as the simple one I posted before: 7.5 sec vs 6.2 sec to read the symbols from gdb.exe. However, what does this change mean in terms of GDB's support for symbols with non-ASCII names? AFAIU, libiberty's TOLOWER only handles ASCII characters. If it's okay for GDB to compare case-insensitively only ASCII characters, then is the above patch mature enough to go to the gdb-13 branch?