From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79392-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5463 invoked by alias); 7 Mar 2011 20:51:08 -0000
Received: (qmail 5454 invoked by uid 22791); 7 Mar 2011 20:51:08 -0000
X-SWARE-Spam-Status: No, hits=-0.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Mar 2011 20:51:01 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LHP00J00GG1XT00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Mon, 07 Mar 2011 22:50:29 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.124.58.59]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LHP00JI2GK3X410@a-mtaout22.012.net.il>; Mon, 07 Mar 2011 22:50:29 +0200 (IST)
Date: Mon, 07 Mar 2011 20:56:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch] Implement set/show callback functions in gdb.Parameter
In-reply-to: <m34o7efz0t.fsf@redhat.com>
To: pmuldoon@redhat.com
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83ei6ihd26.fsf@gnu.org>
References: <m3bp2dw9io.fsf@redhat.com> <m3d3mc80js.fsf@fleche.redhat.com> <m34o7ehqht.fsf@redhat.com> <83fwqyhe6y.fsf@gnu.org> <m34o7efz0t.fsf@redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00505.txt.bz2

> From: Phil Muldoon <pmuldoon@redhat.com>
> Cc: tromey@redhat.com, gdb-patches@sourceware.org
> Date: Mon, 07 Mar 2011 20:37:06 +0000
> 
> >> +@defop Operation {parameter} get_set_string self
> >> +@value{GDBN} will call this method when a parameter has been
> >> +invoked via the @code{set} API (for example, @kbd{set foo off}).  The
> >
> > Calling an operation a "parameter" is not the best idea.  Already you
> > need to talk about "invoking a parameter", which sounds awkward.  Can
> > we find a better word here?
> 
> 
> Well this is an operation in a gdb.Parameter.  Not sure what else to
> call it.  What do you think?

Then how about rephrasing the description like this:

  @value{GDBN} will call this method when @var{parameter}'s value has
  been changed via the @code{set} API (for example, @kbd{set foo off}).

Would this be accurate?

For the get_show_string, I would suggest

  @value{GDBN} will call this method when @var{parameter}'s
  @code{show} API has been invoked (for example, @kbd{show foo}).

WDYT?