From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-81495-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29874 invoked by alias); 7 Jun 2011 07:10:35 -0000
Received: (qmail 29865 invoked by uid 22791); 7 Jun 2011 07:10:33 -0000
X-SWARE-Spam-Status: No, hits=-0.6 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_WEB,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 07 Jun 2011 07:10:15 +0000
Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LME00G00RVENG00@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Tue, 07 Jun 2011 10:09:51 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([84.229.223.140]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LME00G9YRWED180@a-mtaout23.012.net.il>; Tue, 07 Jun 2011 10:09:51 +0300 (IDT)
Date: Tue, 07 Jun 2011 07:10:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v2] tracepoint: add new trace command "printf" and agent expression "printf" [3] doc
In-reply-to: <BANLkTik5xRmAjprmBJs5f0_KQyu=dDtAMQ@mail.gmail.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches@sourceware.org, brobecker@adacore.com, dje@google.com, stan@codesourcery.com, tromey@redhat.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83ei36ce2o.fsf@gnu.org>
References: <AANLkTinGZvnz68ao3HmnhFizze+q4YwsjM0psgisT51i@mail.gmail.com> <20110224085616.GB2495@adacore.com> <AANLkTimxWQwRNWbFLa3F6uAiUFYiuyGDaq_bZ_aMOE1X@mail.gmail.com> <BANLkTik5xRmAjprmBJs5f0_KQyu=dDtAMQ@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-06/txt/msg00093.txt.bz2

> From: Hui Zhu <teawater@gmail.com>
> Date: Tue, 7 Jun 2011 14:32:55 +0800
> Cc: Joel Brobecker <brobecker@adacore.com>, Doug Evans <dje@google.com>, 
> 	Stan Shebs <stan@codesourcery.com>, Tom Tromey <tromey@redhat.com>, Eli Zaretskii <eliz@gnu.org>
> 
> +@item @code{printf} (0x31) @var{n} @var{template}: @result{}
> +Print the values in the stack under the control of the string template.
> +The end of @var{template} is 0x00.

I don't understand the last sentence.  Do you mean to say that the
template is a null-terminated string?

> +If @var{n} is 0, just output the string template.
> +If @var{n} is 1, pop a value from the stack and print it under the control
> +of the string template.

Does this support only a single value?  That's not what one would
normally expect from something called "printf".  If it can pop more
than one value, that should be documented.

> +@kindex printf
> +@item printf @var{template}, @var{expressions}@dots{}
> +Print the values of one or more @var{expressions} under the control of
> +the string @var{template} in @code{gdbserver} part.

What do you mean by "in @code{gdbserver} part"?

> +The command format is with simple @code{printf} (@pxref{Output, printf}).

This sentence's intent is not clear to me.  Can you explain what were
you trying to say?

Thanks.