From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-83010-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6453 invoked by alias); 13 Aug 2011 10:50:47 -0000
Received: (qmail 6444 invoked by uid 22791); 13 Aug 2011 10:50:46 -0000
X-SWARE-Spam-Status: No, hits=-1.0 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 13 Aug 2011 10:50:32 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LPV00G004HAMQ00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Sat, 13 Aug 2011 13:50:30 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([84.229.155.132]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LPV00FIW4S5OCA0@a-mtaout22.012.net.il>; Sat, 13 Aug 2011 13:50:30 +0300 (IDT)
Date: Sat, 13 Aug 2011 10:50:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFC] Fix problems related to Mingw/DJGPP file names containing colons
In-reply-to: <003c01cc59a1$49cc1520$dd643f60$%muller@ics-cnrs.unistra.fr>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83ei0pwpol.fsf@gnu.org>
References: <004901cc5907$85006320$8f012960$%muller@ics-cnrs.unistra.fr> <83vcu2wnvj.fsf@gnu.org> <m34o1mlezb.fsf@fleche.redhat.com> <83sjp6wmhb.fsf@gnu.org> <003c01cc59a1$49cc1520$dd643f60$%muller@ics-cnrs.unistra.fr>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-08/txt/msg00270.txt.bz2

> From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> Cc: <gdb-patches@sourceware.org>
> Date: Sat, 13 Aug 2011 12:10:53 +0200
> 
> > It's ugly and fragile, because the original name could be quoted.
> 
> +      /* Quote filenames containing ':' characters to avoid problems.  */
> +      if (strchr (filename, ':') != NULL && filename[0] != '"')
> +	sprintf (canonical_name, "\"%s\":%d", filename, sal->line);
> 
>   The second condition already takes care of not
> quoting already quoted file names.

What if the original name already includes quote characters?  That can
happen on Posix platforms.