From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19309 invoked by alias); 3 Nov 2012 07:42:12 -0000 Received: (qmail 19298 invoked by uid 22791); 3 Nov 2012 07:42:11 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 03 Nov 2012 07:42:05 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MCW00900ILXH300@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Sat, 03 Nov 2012 09:41:34 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MCW0091NIP9HI00@a-mtaout22.012.net.il>; Sat, 03 Nov 2012 09:41:34 +0200 (IST) Date: Sat, 03 Nov 2012 07:42:00 -0000 From: Eli Zaretskii Subject: Re: Add fullname field in disassembly output In-reply-to: <5093A785.3060103@broadcom.com> To: Andrew Burgess Cc: gdb-patches@sourceware.org, palves@redhat.com Reply-to: Eli Zaretskii Message-id: <83ehkb5e1p.fsf@gnu.org> References: <506DB4B8.5030001@broadcom.com> <5085B9D5.80508@broadcom.com> <50913B7F.10707@redhat.com> <5093A785.3060103@broadcom.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00073.txt.bz2 > Date: Fri, 2 Nov 2012 10:59:17 +0000 > From: "Andrew Burgess" > cc: "Pedro Alves" > > On 31/10/2012 2:53 PM, Pedro Alves wrote: > > >> Ok to commit? > > > > Not yet, sorry. This new field needs to be documented in the manual, and mentioned in NEWS. > > Sorry, I should have realised I'd need to do these things. > > Latest version of patch, includes fullname field, test > updates, noted in documentation and in NEWS file. Thanks. > + ** The data-disassemble command response will include a "fullname" field > + containing the full path to the source file when gdb can determine the > + full path, and source has been requested in the output. Please use "absolute file name" or just "file name" instead of "path". GNU coding standards frown upon use of "path" for anything except PATH-style directory lists. > -file="/kwikemart/marge/ezannoni/flathead-dev/devo/gdb/ \ > - testsuite/gdb.mi/basics.c",line_asm_insn=[ > +file="../../../src/gdb/testsuite/gdb.mi/basics.c", > +fullname="/absolute/path/to/src/gdb/testsuite/ \ > +gdb.mi/basics.c",line_asm_insn=[ It would be better not to break the last line in the middle of a file name, as that could confuse the reader into thinking that there's a blank in the middle. > -file="/kwikemart/marge/ezannoni/flathead-dev/devo/gdb/ \ > - testsuite/gdb.mi/basics.c",line_asm_insn=[ > +file="../../../src/gdb/testsuite/gdb.mi/basics.c", > +fullname="/absolute/path/to/src/gdb/testsuite/ \ > +gdb.mi/basics.c",line_asm_insn=[ Same here. The documentation parts are OK with those changes.