From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5468 invoked by alias); 25 Sep 2013 12:33:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5457 invoked by uid 89); 25 Sep 2013 12:33:17 -0000 Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Sep 2013 12:33:17 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: mtaout22.012.net.il Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MTO00E00LEX8X00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Wed, 25 Sep 2013 15:33:14 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MTO00D8CLJEV6B0@a-mtaout22.012.net.il>; Wed, 25 Sep 2013 15:33:14 +0300 (IDT) Date: Wed, 25 Sep 2013 12:33:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH V4 0/8] Intel(R) MPX register support In-reply-to: To: "Tedeschi, Walfred" Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83eh8dgjxh.fsf@gnu.org> References: <1378373188-31144-1-git-send-email-walfred.tedeschi@intel.com> <83y57bbo6q.fsf@gnu.org> <83vc2aj6qr.fsf@gnu.org> X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00891.txt.bz2 > From: "Tedeschi, Walfred" > CC: "gdb-patches@sourceware.org" > Date: Wed, 25 Sep 2013 11:51:23 +0000 > > Common code I meant the target dependent files, i.e. amd64-tdep.c and i386-tdep.c. > > We added code to support Linux only. Linux registers are processed at amd64-tdep-linux.c and i386-tdep-linux.c as well as amd64-linux-nat.c and i386-linux-nat.c. > > In order to implement the same features for windows we should have modified the amd64-tdep-windows and i386-tdep-windows.c and for Darwin amd64-tdep-darwin and i386-tdep-darwin.c for bsd there would be also some change on amd64bsd-native.c and i386bsd-native.c. Additionally we OS support that is still not ready on the other platforms. > > I hope to have clarified. I'm sorry to insist, but that's exactly my question: why were the changes done in Linux-specific i386-tdep-linux.c etc., and not in the CPU-specific i386-tdep.c etc.? These registers are specific to a CPU, not to an OS, aren't they?