Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: small request regarding commits in binutils-gdb.git
Date: Wed, 15 Jan 2014 16:57:00 -0000	[thread overview]
Message-ID: <83eh4941yu.fsf@gnu.org> (raw)
In-Reply-To: <20140115162518.GL4762@adacore.com>

> Date: Wed, 15 Jan 2014 20:25:18 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: binutils@sourceware.org, gdb-patches@sourceware.org
> 
> But even with this example, it isn't just a repeat.

I didn't say it was just a repeat, I said most of it just repeats.

> The text before the ChangeLog says what the intent of the patch is,
> and provides extra information that usually doesn't go into the
> ChangeLog entry. For example, it says "This makes it usable in more
> places".

Why not have this as part of the log entry.  Here's an example (from
Emacs):

	* window.h (struct window): Replace hchild, vchild and buffer slots
	with a single contents slot.  This is possible because each valid
	window may have either the child window (in vertical or horizontal
	combination) or buffer to display (for the leaf window).  Using that,
	a lot of operations to traverse and/or change window hierarchies may
	be simplified.  New member horizontal is used to distinguish between
	horizontal and vertical combinations of internal windows.


  reply	other threads:[~2014-01-15 16:57 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-15 12:12 Joel Brobecker
2014-01-15 15:28 ` Mike Frysinger
2014-01-15 15:51 ` Tom Tromey
2014-01-15 16:04 ` Eli Zaretskii
2014-01-15 16:25   ` Joel Brobecker
2014-01-15 16:57     ` Eli Zaretskii [this message]
2014-01-15 17:12       ` Mike Frysinger
2014-01-15 19:48         ` Fred Cooke
2014-01-15 20:02           ` Mike Frysinger
2014-01-15 20:38             ` Eli Zaretskii
2014-01-15 20:57               ` Mike Frysinger
2014-01-15 21:09                 ` Eli Zaretskii
2014-01-16  2:11                   ` Alan Modra
2014-01-16  2:17                   ` Joel Brobecker
2014-01-16  1:41             ` Fred Cooke
2014-01-16  2:41               ` Mike Frysinger
2014-01-15 16:50   ` Pedro Alves
2014-01-15 17:03     ` Tom Tromey
2014-01-15 18:07   ` Gary Benson
2014-01-16 11:41   ` Jose E. Marchesi
2014-01-15 19:31 ` Cary Coutant
2014-01-15 19:45   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83eh4941yu.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=binutils@sourceware.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox