From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-112777-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7222 invoked by alias); 24 May 2014 07:13:47 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 7207 invoked by uid 89); 24 May 2014 07:13:46 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout23.012.net.il
Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 24 May 2014 07:13:45 +0000
Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0N6200600H7MM300@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Sat, 24 May 2014 10:13:42 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N62006AXHEUL020@a-mtaout23.012.net.il>; Sat, 24 May 2014 10:13:42 +0300 (IDT)
Date: Sat, 24 May 2014 07:13:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 1/4 v18] Add xmethod documentation and NEWS entry
In-reply-to: <CAGyQ6gwiEYCmBRwaiJsK5pyxAhYA6qzQTpebHzSsk+Kque2Mdw@mail.gmail.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83egzjlkco.fsf@gnu.org>
References: <CAGyQ6gwiEYCmBRwaiJsK5pyxAhYA6qzQTpebHzSsk+Kque2Mdw@mail.gmail.com>
X-IsSubscribed: yes
X-SW-Source: 2014-05/txt/msg00615.txt.bz2

> Date: Fri, 23 May 2014 14:55:01 -0700
> From: Siva Chandra <sivachandra@google.com>
> 
> This part was approved (I think) previously but sending it out with
> version synced to v18. Also, the name changed from "debug method" to
> "xmethod". Hence, I think another review is required.

You've got it.

> +@defun XMethodWorker.invoke(self, obj, args)
> +This is the method which does the @emph{work} of the xmethod.
> +@var{obj} is the object on which the method is being invoked, and
> +@var{args} is the tuple of arguments to the method.  @var{obj} and the
> +elements of @var{args} are @code{gdb.Value} objects.

It is best not to begin a sentence with "@var{something}", since in
the printed manual that will produce a sentence starting from a
lower-case letter.

Otherwise, OK.  Thanks.