Re: Remove conditionals for ANSI-standard signals

Doug Evans
2014-06-05T16:10:18Z

On Thu, Jun 5, 2014 at 7:50 AM, Gary Benson <gbenson@redhat.com> wrote:
> Hi all,
>
> This patch removes all preprocessor conditionals for ANSI-standard
> signals (SIGINT, SIGILL, SIGABRT, SIGFPE, SIGSEGV and SIGTERM) which
> are guaranteed to always be defined.
>
> Built and regtested on RHEL6.5 x86_64.
>
> Ok to commit?
>
> Cheers,
> Gary
>
> --
> gdb/
> 2014-06-05 Gary Benson <gbenson@redhat.com>
>
> * common/signals.c: Remove preprocessor conditionals for
> always-defined signals SIGINT, SIGILL, SIGABRT, SIGFPE,
> SIGSEGV and SIGTERM.
> * proc-events.c: Likewise.

Ok, with one request.

IWBN to have one more patch after this one, as its preferable to move
code around as a separate patch.
I can't see any sorting order to the places that have all the #ifdefs
(common/signals.c in particular), and I wonder if it would be useful
to put the non-#ifdef'd signals first with a comment explaining why
they don't have #ifdefs.
One could also sort them alphabetically of course too, of course,
within each group (non-#ifdef, #ifdef), but I don't have a strong
opinion on that.