From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74661 invoked by alias); 8 Dec 2017 14:15:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74647 invoked by uid 89); 8 Dec 2017 14:15:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Dec 2017 14:15:47 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eNJRF-0003Pp-NR for gdb-patches@sourceware.org; Fri, 08 Dec 2017 09:15:46 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39446) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNJRF-0003PU-KA; Fri, 08 Dec 2017 09:15:41 -0500 Received: from [176.228.60.248] (port=3121 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eNJRE-0004G7-3o; Fri, 08 Dec 2017 09:15:41 -0500 Date: Fri, 08 Dec 2017 14:15:00 -0000 Message-Id: <83efo5wbke.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi CC: gdb-patches@sourceware.org In-reply-to: <1512686013-24658-1-git-send-email-simon.marchi@ericsson.com> (message from Simon Marchi on Thu, 7 Dec 2017 17:33:33 -0500) Subject: Re: [PATCH] python: Add qualified parameter to gdb.Breakpoint Reply-to: Eli Zaretskii References: <1512686013-24658-1-git-send-email-simon.marchi@ericsson.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00186.txt.bz2 > From: Simon Marchi > CC: Simon Marchi > Date: Thu, 7 Dec 2017 17:33:33 -0500 > > This patch adds the possibility to pass a qualified=True|False parameter > when creating a breakpoint in Python. It is equivalent to using > -qualified in a linespec. The parameter actually accepts any Python > value, and converts it to boolean using Python's standard rules for > that (https://docs.python.org/3/library/stdtypes.html#truth). > > Unlike the -source/-line/-function/-label parameters, it is possible to > use -qualified with a "normal" (non-explicit) linespec. Therefore, it > is possible (unlike these other parameters) to use this new parameter > along with the spec parameter. > > I updated the py-breakpoint.exp test. To be able to test multiple > locations using a namespace, I had to switch the test case to compile as > C++. If we really wanted to, we could run it as both C and C++, but > omit the C++-specific parts when running it as C. > > gdb/ChangeLog: > > * location.h (string_to_event_location): Add match_type > parameter. > * location.c (string_to_event_location): Likewise. > * python/py-breakpoint.c (bppy_init): Handle qualified > parameter. > > gdb/doc/ChangeLog: > > * python.texi (Manipulating breakpoints using Python): Document > qualified parameter to gdb.Breakpoint. > > gdb/testsuite/ChangeLog: > > * gdb.python/py-breakpoint.c (foo_ns::multiply): New function. > * gdb.python/py-breakpoint.exp: Compile the test case as c++, > call test_bkpt_qualified. > (test_bkpt_qualified): New proc. OK for the documentation part. (Do we need a NEWS entry?)