From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-146698-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 88478 invoked by alias); 19 Apr 2018 19:31:23 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 88006 invoked by uid 89); 19 Apr 2018 19:31:23 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:4.82, H*r:sk:RSA_AES
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Apr 2018 19:31:21 +0000
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1f9FH1-0008Ky-Vg	for gdb-patches@sourceware.org; Thu, 19 Apr 2018 15:31:19 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43263)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1f9FH1-0008Kp-RW; Thu, 19 Apr 2018 15:31:15 -0400
Received: from [176.228.60.248] (port=3937 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1f9FH1-0002Po-6c; Thu, 19 Apr 2018 15:31:15 -0400
Date: Thu, 19 Apr 2018 19:31:00 -0000
Message-Id: <83efjbyovj.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
CC: gdb-patches@sourceware.org
In-reply-to: <20180419191539.661-8-tom@tromey.com> (message from Tom Tromey on	Thu, 19 Apr 2018 13:15:38 -0600)
Subject: Re: [RFA 7/8] Allow breakpoint commands to be set from Python
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <20180419191539.661-1-tom@tromey.com> <20180419191539.661-8-tom@tromey.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-IsSubscribed: yes
X-SW-Source: 2018-04/txt/msg00390.txt.bz2

> From: Tom Tromey <tom@tromey.com>
> Cc: Tom Tromey <tom@tromey.com>
> Date: Thu, 19 Apr 2018 13:15:38 -0600
> 
> This changes the Python API so that breakpoint commands can be set by
> writing to the "commands" attribute.
> 
> 2018-04-19  Tom Tromey  <tom@tromey.com>
> 
> 	PR python/22731:
> 	* NEWS: Mention that breakpoint commands are writable.
> 	* python/py-breakpoint.c (bppy_set_commands): New function.
> 	(breakpoint_object_getset) <"commands">: Use it.
> 
> doc/ChangeLog
> 2018-04-19  Tom Tromey  <tom@tromey.com>
> 
> 	PR python/22731:
> 	* python.texi (Breakpoints In Python): Mention that "commands" is
> 	writable.
> 
> testsuite/ChangeLog
> 2018-04-19  Tom Tromey  <tom@tromey.com>
> 
> 	PR python/22731:
> 	* gdb.python/py-breakpoint.exp: Test setting breakpoint commands.

OK for the documentation parts.

Thanks.