From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87161 invoked by alias); 26 Jul 2018 17:47:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87133 invoked by uid 89); 26 Jul 2018 17:47:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Jul 2018 17:47:26 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fikMB-0008Rb-Lf for gdb-patches@sourceware.org; Thu, 26 Jul 2018 13:47:23 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59018) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fikMB-0008RD-HC; Thu, 26 Jul 2018 13:47:19 -0400 Received: from [176.228.60.248] (port=1528 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fikMB-0006Mx-0J; Thu, 26 Jul 2018 13:47:19 -0400 Date: Thu, 26 Jul 2018 17:47:00 -0000 Message-Id: <83effpubx5.fsf@gnu.org> From: Eli Zaretskii To: Jan Vrany CC: gdb-patches@sourceware.org In-reply-to: <20180726145557.18867-1-jan.vrany@fit.cvut.cz> (message from Jan Vrany on Thu, 26 Jul 2018 15:55:57 +0100) Subject: Re: [RFC] mi: add -a option to the "-data-disassemble" command References: <83pnzpad0o.fsf@gnu.org> <20180726145557.18867-1-jan.vrany@fit.cvut.cz> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00727.txt.bz2 > From: Jan Vrany > Cc: Jan Vrany > Date: Thu, 26 Jul 2018 15:55:57 +0100 > > diff --git a/gdb/NEWS b/gdb/NEWS > index 839466e7e0..3367be4375 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -3,6 +3,9 @@ > > *** Changes since GDB 8.1 > > +* The '-data-disassemble' MI command now accepts an '-a' option to disassemble ^^^^^^^^^^^^^^ "the '-a' option" > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 7fb6ac5636..af2a0948c3 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -30947,6 +30947,7 @@ For details about what an addressable memory unit is, > @smallexample > -data-disassemble > [ -s @var{start-addr} -e @var{end-addr} ] > + | [ -a @var{addr} ] > | [ -f @var{filename} -l @var{linenum} [ -n @var{lines} ] ] > -- @var{mode} > @end smallexample > @@ -30959,6 +30960,11 @@ Where: > is the beginning address (or @code{$pc}) > @item @var{end-addr} > is the end address > +@item @var{addr} > +is the address anywhere in function code (or function name). If @var{addr} > +is specified, the whole function surrounding that address will be disassembled. > +If @var{addr} is a function name, the whole function with that name will be > +disassembled. You never mention the -a option in the text. I think you should. Thanks.