From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40937 invoked by alias); 14 Aug 2018 14:40:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40928 invoked by uid 89); 14 Aug 2018 14:40:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:esmtpsa, H*RU:esmtpsa X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Aug 2018 14:40:48 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fpaV2-0002aK-8D for gdb-patches@sourceware.org; Tue, 14 Aug 2018 10:40:47 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fpaV2-0002aG-3E; Tue, 14 Aug 2018 10:40:44 -0400 Received: from [176.228.60.248] (port=1706 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fpaV1-0001y9-Eh; Tue, 14 Aug 2018 10:40:43 -0400 Date: Tue, 14 Aug 2018 14:40:00 -0000 Message-Id: <83eff1j9jf.fsf@gnu.org> From: Eli Zaretskii To: Jan Vrany CC: gdb-patches@sourceware.org In-reply-to: <20180814091543.29917-1-jan.vrany@fit.cvut.cz> (message from Jan Vrany on Tue, 14 Aug 2018 10:15:43 +0100) Subject: Re: [RFC] mi: add -a option to the "-data-disassemble" command References: <71a83e5b-0662-e269-5b94-be7fc2ce5687@redhat.com> <20180814091543.29917-1-jan.vrany@fit.cvut.cz> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00352.txt.bz2 > From: Jan Vrany > Cc: Jan Vrany > Date: Tue, 14 Aug 2018 10:15:43 +0100 > > A CLI command "disassemble" allows use to specify a single > address - in that case function surrounding that address is > disassembled. > > This commit adds this feature to MI command "-data-disassemble". Thanks. > *** Changes since GDB 8.2 > > +* The '-data-disassemble' MI command now accepts the '-a' option to disassemble > + the whole function surrounding given program counter value or function name. This is OK, but please make the lines shorter by a couple of characters. > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -31208,6 +31208,7 @@ For details about what an addressable memory unit is, > @smallexample > -data-disassemble > [ -s @var{start-addr} -e @var{end-addr} ] > + | [ -a @var{addr} ] > | [ -f @var{filename} -l @var{linenum} [ -n @var{lines} ] ] > -- @var{mode} > @end smallexample > @@ -31220,6 +31221,11 @@ Where: > is the beginning address (or @code{$pc}) > @item @var{end-addr} > is the end address > +@item @var{addr} > +is the address anywhere in function code (or function name). If @code{-a} > +@var{addr} is used, the whole function surrounding that address will be This separates -a and ADDR, which can confuse the reader. Suggest to reword: @item @var{addr} is either the name of a function, or an address anywhere in function's code. If @code{-a} followed by an @var{addr} is used, the specified function will be disassembled > +disassembled. If @var{addr} is a function name, the whole function with that > +name will be disassembled. The last sentence can be dropped if you agree with my rewording, as it is now redundant. The documentation parts are OK with the above fixed.