Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: John Baldwin <jhb@FreeBSD.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 2/3] Add an optional "alias" attribute to syscall entries.
Date: Fri, 09 Nov 2018 20:18:00 -0000	[thread overview]
Message-ID: <83efbuattx.fsf@gnu.org> (raw)
In-Reply-To: <20181109200432.84491-3-jhb@FreeBSD.org> (message from John	Baldwin on Fri, 9 Nov 2018 12:04:31 -0800)

> From: John Baldwin <jhb@FreeBSD.org>
> Date: Fri,  9 Nov 2018 12:04:31 -0800
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index ff9b192a38..ff225f361e 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -38,6 +38,11 @@
>    requires the use of a keyword.  Selecting a frame by level is
>    unchanged.  The MI comment "-stack-select-frame" is unchanged.
>  
> +* System call catchpoints now support system call aliases.  This is
> +  used with the FreeBSD system call list so that system call
> +  catchpoints will also trigger for legacy system call numbers used by
> +  older FreeBSD binaries.

IMO, this is very abstract and too vague to be useful.  Since we won't
have anything more detailed in the manual, would it be possible to
make this description more concrete?  E.g., how about using some of
the text and examples you used in your description of the issue:

> When setting a syscall catchpoint by name, catch syscalls whose name
> or alias matches the requested string.
> 
> When the ABI of a system call is changed in the FreeBSD kernel, this
> is implemented by leaving a compatibility system call using the old
> ABI at the existing "slot" and allocating a new system call for the
> version using the new ABI.  For example, new fields were added to the
> 'struct kevent' used by the kevent() system call in FreeBSD 12.  The
> previous kevent() system call in FreeBSD 12 kernels is now called
> freebsd11_kevent() and is still used by older binaries compiled
> against the older ABI.  The freebsd11_kevent() system call can be
> tagged with an "alias" attribute of "kevent" permitting 'catch syscall
> kevent' to catch both system calls and providing the expected user
> behavior for both old and new binaries.  It also provides the expected
> behavior if GDB is compiled on an older host (such as a FreeBSD 11
> host).

Thanks.


  reply	other threads:[~2018-11-09 20:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-09 20:04 [PATCH v3 0/3] Update FreeBSD's syscall table John Baldwin
2018-11-09 20:04 ` [PATCH v3 2/3] Add an optional "alias" attribute to syscall entries John Baldwin
2018-11-09 20:18   ` Eli Zaretskii [this message]
2018-11-16 17:44     ` John Baldwin
2018-11-16 19:37       ` Eli Zaretskii
2018-11-27 17:13     ` Pedro Alves
2018-11-27 21:54       ` John Baldwin
2018-11-28  6:31         ` Eli Zaretskii
     [not found]         ` <34fcc769-4533-31bf-d258-36c6110037e0@redhat.com>
2018-11-28 17:22           ` John Baldwin
2018-11-28 17:44             ` Eli Zaretskii
2018-11-28 18:00               ` John Baldwin
2018-11-28 18:31                 ` Eli Zaretskii
2018-11-28 18:34                 ` Pedro Alves
2018-11-28 19:15                   ` John Baldwin
2018-11-28 19:21                   ` Eli Zaretskii
2018-11-09 20:04 ` [PATCH v3 1/3] Change get_syscalls_by_group to append to an existing vector of integers John Baldwin
2018-11-09 20:04 ` [PATCH v3 3/3] Update the FreeBSD system call table to match FreeBSD 12.0 John Baldwin
     [not found] ` <7ffda341-7706-d541-939e-f45a7a3f9bd7@FreeBSD.org>
2018-11-27 17:20   ` [PATCH v3 0/3] Update FreeBSD's syscall table Pedro Alves
2018-11-27 20:00     ` John Baldwin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83efbuattx.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jhb@FreeBSD.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox