From: Eli Zaretskii <eliz@gnu.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: MinGW build failure for GDB 8.2.90 with source-highlight
Date: Thu, 07 Mar 2019 20:13:00 -0000 [thread overview]
Message-ID: <83ef7ibfzb.fsf@gnu.org> (raw)
In-Reply-To: <a1052036b5ace1d67f905d8ce61e0086@polymtl.ca> (message from Simon Marchi on Thu, 07 Mar 2019 11:59:47 -0500)
> Date: Thu, 07 Mar 2019 11:59:47 -0500
> From: Simon Marchi <simon.marchi@polymtl.ca>
> Cc: gdb-patches@sourceware.org
>
> Since there are problems to fix with open on mingw (according to [1]), I
> think it's fine that gnulib provides replacements.
For calls into the C runtime, sure. But I don't think they can
replace the methods reflected to C++, because libstdc++ will call the
C runtime against which it was linked, at least on MS-Windows.
> Undefining the macros seems dangerous too, if you actually use the
> "open" function from the C standard library on a system where it is
> buggy, you want to end up with gnulib's fixed version...
There's no such call in source-cache.c, AFAICS.
next prev parent reply other threads:[~2019-03-07 20:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 14:36 Eli Zaretskii
2019-03-07 16:59 ` Simon Marchi
2019-03-07 17:11 ` Pedro Alves
2019-03-07 18:09 ` Simon Marchi
2019-03-07 18:20 ` Pedro Alves
2019-03-07 18:24 ` Simon Marchi
2019-03-07 20:29 ` Eli Zaretskii
2019-03-07 20:13 ` Eli Zaretskii [this message]
2019-03-11 14:18 ` Eli Zaretskii
2019-03-12 2:31 ` Simon Marchi
2019-03-12 10:52 ` Pedro Alves
2019-03-12 13:43 ` Simon Marchi
2019-03-12 15:49 ` Eli Zaretskii
2019-03-12 16:29 ` Simon Marchi
2019-03-12 17:53 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ef7ibfzb.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox