From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27018 invoked by alias); 16 Mar 2019 17:59:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27006 invoked by uid 89); 16 Mar 2019 17:59:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=H*f:sk:b699ee4, pressing, H*f:sk:831s381, whereby X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 16 Mar 2019 17:59:11 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34282) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5DaP-0008Co-40; Sat, 16 Mar 2019 13:59:09 -0400 Received: from [176.228.60.248] (port=1522 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h5DaJ-0003kc-4t; Sat, 16 Mar 2019 13:59:07 -0400 Date: Sat, 16 Mar 2019 17:59:00 -0000 Message-Id: <83ef76ya4g.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: tromey@adacore.com, gdb-patches@sourceware.org In-reply-to: <432e3aa4-a006-bace-657b-b49ec2314190@redhat.com> (message from Pedro Alves on Fri, 15 Mar 2019 13:56:39 +0000) Subject: Re: Fix pressing down in the TUI (Re: [RFC 8.3 0/3] Some style fixes) References: <20190308210433.32683-1-tromey@adacore.com> <83pnr08tc8.fsf@gnu.org> <83zhq26fcw.fsf@gnu.org> <874l899nh3.fsf@tromey.com> <8336ns3uv4.fsf@gnu.org> <831s381cp5.fsf@gnu.org> <432e3aa4-a006-bace-657b-b49ec2314190@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00335.txt.bz2 > Cc: tromey@adacore.com, gdb-patches@sourceware.org > From: Pedro Alves > Date: Fri, 15 Mar 2019 13:56:39 +0000 > > >> I think this should return false if open_source_file fails? > > > > How could it fail if input.is_open returns non-zero? Are you thinking > > about some race, whereby something deletes the file after the > > constructor for 'input' returns? > > Yes, something like that. The possibility is small, but non-zero > that it could fail. And if it does, we end up with s->nlines > uninitialized again. OK, pushed with that change to both branches. Thanks.