From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-155603-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 117657 invoked by alias); 25 Apr 2019 05:58:27 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 117649 invoked by uid 89); 25 Apr 2019 05:58:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=facilities
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Apr 2019 05:58:26 +0000
Received: from fencepost.gnu.org ([2001:470:142:3::e]:45114)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1hJXOp-0007Rj-JR; Thu, 25 Apr 2019 01:58:23 -0400
Received: from [176.228.60.248] (port=4304 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1hJXOo-0000jS-1m; Thu, 25 Apr 2019 01:58:22 -0400
Date: Thu, 25 Apr 2019 05:58:00 -0000
Message-Id: <83ef5q1v9x.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
CC: philippe.waroquiers@skynet.be, gdb-patches@sourceware.org
In-reply-to: <871s1rf7q0.fsf@tromey.com> (message from Tom Tromey on Wed, 24	Apr 2019 14:50:47 -0600)
Subject: Re: [RFA 2/4] Implement | (pipe) command.
References: <20190420212153.30934-1-philippe.waroquiers@skynet.be>	<20190420212153.30934-3-philippe.waroquiers@skynet.be> <871s1rf7q0.fsf@tromey.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-IsSubscribed: yes
X-SW-Source: 2019-04/txt/msg00508.txt.bz2

> From: Tom Tromey <tom@tromey.com>
> Cc: gdb-patches@sourceware.org
> Date: Wed, 24 Apr 2019 14:50:47 -0600
> 
> Philippe> +  to = popen (shell_command, "w");
> 
> I wonder if it's better to use libiberty's pexecute code?
> This may avoid the WIFEXITED problems.

Libiberty's pexecute doesn't solve the WIFEXITED problem, AFAICT, it
just returns the exit status to the caller, and I see no facilities
there to help interpret that status with platform-independent code.
Did I miss something?