From: Eli Zaretskii via Gdb-patches <gdb-patches@sourceware.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb: introduce new 'maint flush ' prefix command
Date: Mon, 23 Nov 2020 17:28:03 +0200 [thread overview]
Message-ID: <83eekkw0sc.fsf@gnu.org> (raw)
In-Reply-To: <e054bb9a202f9f471581ba364adff0bc8cdb9f88.1606126286.git.andrew.burgess@embecosm.com> (message from Andrew Burgess on Mon, 23 Nov 2020 10:39:36 +0000)
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Mon, 23 Nov 2020 10:39:36 +0000
>
> diff --git a/gdb/NEWS b/gdb/NEWS
> index d1f721c3953..b07b054223f 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -27,6 +27,11 @@ set debug event-loop
> show debug event-loop
> Control the display of debug output about GDB's event loop.
>
> +maintenance flush symbol-cache
> +maintenance flush register-cache
> + These new commands are equivalent to the already existing commands
> + 'maintenance flush-symbol-cache' and 'flushregs' respectively.
> +
> * Changed commands
This part is OK.
> +@kindex maint flush symbol-cache
> @kindex maint flush-symbol-cache
> @cindex symbol cache, flushing
> +@item maint flush symbol-cache
> @item maint flush-symbol-cache
You cannot have more than 1 @item in a row. All but the first one
have to be @itemx instead.
> +@kindex maint flush register-cache
> @kindex flushregs
> +@cindex register cache, flushing
> +@item maint flush register-cache
> @item flushregs
Same here.
The documentation parts are okay with this nit fixed. Thanks.
next prev parent reply other threads:[~2020-11-23 15:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 10:39 [PATCH 0/2] Organise maintenance commands that flush caches Andrew Burgess
2020-11-23 10:39 ` [PATCH 1/2] gdb: introduce new 'maint flush ' prefix command Andrew Burgess
2020-11-23 15:28 ` Eli Zaretskii via Gdb-patches [this message]
2020-11-23 16:24 ` Luis Machado via Gdb-patches
2020-12-03 17:23 ` Tom Tromey
2020-12-13 12:43 ` Andrew Burgess
2020-11-23 10:39 ` [PATCH 2/2] gdb: new command 'maint flush dcache' Andrew Burgess
2020-11-23 15:28 ` Eli Zaretskii via Gdb-patches
2020-11-23 16:28 ` Luis Machado via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83eekkw0sc.fsf@gnu.org \
--to=gdb-patches@sourceware.org \
--cc=andrew.burgess@embecosm.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox