From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 9XAwLgYwTGNmTQ0AWB0awg (envelope-from ) for ; Sun, 16 Oct 2022 12:23:34 -0400 Received: by simark.ca (Postfix, from userid 112) id B01871E112; Sun, 16 Oct 2022 12:23:34 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=JJjrXbYa; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5E43D1E0D3 for ; Sun, 16 Oct 2022 12:23:34 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 669D93857B80 for ; Sun, 16 Oct 2022 16:23:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 669D93857B80 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1665937413; bh=tOvEX5RGAB2Tab/eRWWj7SG+dxO8uEt2qcr1iE5ykkc=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=JJjrXbYaji/sjYXcLBEh1dK/laqmA3EC9E6rp1uvYEl8k6X/GcA6eA3IyyOieGg86 Ql8hbHj7ZJBWjFAR2DRqx/pPcZkQL01/jVSu12FAoYj94RJyxgk6CQMo2EBQM020H+ n8zK+UX7W1RoTqVFU0f1PpSBES5pqU5qnXDCqLKU= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 2799F3858D3C for ; Sun, 16 Oct 2022 16:23:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2799F3858D3C Received: from fencepost.gnu.org ([2001:470:142:3::e]:45722) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ok6Ps-0002HF-C1; Sun, 16 Oct 2022 12:23:08 -0400 Received: from [87.69.77.57] (port=3055 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ok6Pq-0004D2-9K; Sun, 16 Oct 2022 12:23:06 -0400 Date: Sun, 16 Oct 2022 19:22:52 +0300 Message-Id: <83edv74u1v.fsf@gnu.org> To: Andrei Pikas In-Reply-To: <20221016160354.30740-1-gdb@mail.api.win> (message from Andrei Pikas on Sun, 16 Oct 2022 19:03:54 +0300) Subject: Re: [PATCH v5] Add an option with a color type. References: <83mt9v51c5.fsf@gnu.org> <20221016160354.30740-1-gdb@mail.api.win> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: gdb@mail.api.win, gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > From: Andrei Pikas > Cc: eliz@gnu.org, > Andrei Pikas > Date: Sun, 16 Oct 2022 19:03:54 +0300 > > +@deffn {Scheme Procedure} color-escape-sequence color is_foreground > +Return string to change terminal's color to this. > + > +@var{is_foreground} If @var{is_foreground} is @code{#t}, then the returned ^^^^^^^^^^^^^^^^^^^^ I believe the underlined part should be deleted. > +sequence will change foreground color. Otherwise, the returned sequence will ^^ Two spaces between sentences, please. > +@defun Color.escape_sequence (@var{self}, @var{is_foreground}) > +Returns string to change terminal's color to this. > + > +@var{is_foreground} If @var{is_foreground} is @code{True}, then the returned > +sequence will change foreground color. Otherwise, the returned sequence will > +change background color. > +@end defun Same here. The documentation parts are okay when these nits are fixed. Thanks.