From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id c3NCL6oa2mTFWAAAWB0awg (envelope-from ) for ; Mon, 14 Aug 2023 08:14:34 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=AswixQOg; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B414B1E0C2; Mon, 14 Aug 2023 08:14:34 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9B6921E098 for ; Mon, 14 Aug 2023 08:14:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ACCD73858418 for ; Mon, 14 Aug 2023 12:14:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ACCD73858418 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1692015271; bh=GMJODooyMLv3zRniciuWitOF8TQUzYOCyBFQ7apfd8s=; h=Date:To:Cc:In-Reply-To:Subject:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=AswixQOgVx+VFqSbf5FyC018f1p7FgWSjdheqJ7LGA/7kO+hJ5VvRJfwr+PllVHHi WaMo9dT/bm2PA0Mkuhx2g1JRs1ZiK6i1n9URGvVYKkVdkQbJKEiA8jGMrQHsQASmKL rwfwjieRyHGvsWelLXm6KJS1ht6+PYEmyzcwIhaE= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 6ED573858C1F for ; Mon, 14 Aug 2023 12:14:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6ED573858C1F Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVWSa-0006mD-0K; Mon, 14 Aug 2023 08:14:12 -0400 Date: Mon, 14 Aug 2023 15:14:12 +0300 Message-Id: <83edk5bz3f.fsf@gnu.org> To: Tom de Vries Cc: gdb-patches@sourceware.org In-Reply-To: <20230814085340.4066-1-tdevries@suse.de> (message from Tom de Vries via Gdb-patches on Mon, 14 Aug 2023 10:53:40 +0200) Subject: Re: [PATCH] [gdb] Fix maint print symbols/psymbols help text References: <20230814085340.4066-1-tdevries@suse.de> X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > Date: Mon, 14 Aug 2023 10:53:40 +0200 > From: Tom de Vries via Gdb-patches > > diff --git a/gdb/psymtab.c b/gdb/psymtab.c > index 64b67078641..bdae9db9676 100644 > --- a/gdb/psymtab.c > +++ b/gdb/psymtab.c > @@ -1687,7 +1687,7 @@ Entries in the partial symbol table are dumped to file OUTFILE,\n\ > or the terminal if OUTFILE is unspecified.\n\ > If ADDRESS is provided, dump only the file for that address.\n\ > If SOURCE is provided, dump only that file's symbols.\n\ > -If OBJFILE is provided, dump only that file's minimal symbols."), > +If OBJFILE is provided, dump only that object file's symbols."), > &maintenanceprintlist); > > add_cmd ("psymtabs", class_maintenance, maintenance_info_psymtabs, _("\ > diff --git a/gdb/symmisc.c b/gdb/symmisc.c > index a65552aa2d2..5b8a82e5137 100644 > --- a/gdb/symmisc.c > +++ b/gdb/symmisc.c > @@ -1052,7 +1052,7 @@ Entries in the full symbol table are dumped to file OUTFILE,\n\ > or the terminal if OUTFILE is unspecified.\n\ > If ADDRESS is provided, dump only the file for that address.\n\ > If SOURCE is provided, dump only that file's symbols.\n\ > -If OBJFILE is provided, dump only that file's minimal symbols."), > +If OBJFILE is provided, dump only that object file's symbols."), > &maintenanceprintlist); > > add_cmd ("msymbols", class_maintenance, maintenance_print_msymbols, _("\ Thanks, this LGTM, but shouldn't the "ADDRESS" line be reworded like below? If ADDRESS is provided, dump only the symbols for that address. If that's not the intent, then can someone please explain the meaning of "the file for that address"?