Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, marc.khouzam@ericsson.com
Subject: Re: [RFC] Allowing all threads of all|current process(es) to be resumed [new command + docs]
Date: Sat, 30 May 2009 17:12:00 -0000	[thread overview]
Message-ID: <83d49q4is6.fsf@gnu.org> (raw)
In-Reply-To: <200905301701.53207.pedro@codesourcery.com>

> From: Pedro Alves <pedro@codesourcery.com>
> Date: Sat, 30 May 2009 17:01:52 +0100
> Cc: marc.khouzam@ericsson.com
> 
> > Can you give at least 2 different use-cases, each one favoring one of
> > the possible behaviors?  I'm not sure I understand the nature of the
> > conflict.
> 
> As I've explained above.

Well, thanks, but your original explanation was clear enough.  What I
was asking for are use-cases where each of the two possible behaviors
would be preferable to the other.

> The conflict is that both "multi-process" implementations behave
> differently, and I'm getting rid of the multi-forks support as-is.

Sorry, I'm confused: if you are getting rid of multi-forks, won't the
conflict go away with it as well?

> Use case is "user wants to resume all processes" vs "user wants to
> resume only the current process".

Yes, but when would the latter be undesirable if the user uses
multi-forks?  If using multi-forks means the user will always want to
resume only the current process, we don't need the new option.

> > > +@cindex resume multiple processes
> > 
> > This index entry is too general.  I suggest something more specific to
> > the aspects you are describing.
> 
> Putting myself in a user's perspective, if I wanted to know how to
> resume multiple process simultaneously, I'd go look for resume, multiple,
> maybe I should add "simultaneously".  Did you have something
> completely different in mind?

You are not describing how to resume multiple process simultaneously.
You are describing how to control whether all of them or only one will
be resumed.

Your new index entry is fine.

> >   Set the mode for scheduling threads of multiple processes.
> > 
> > On second thought, "scheduling" is not the best word here, as GDB is
> > not a scheduler.  How about "continuing the execution"?
> 
> as in:
> 
>  Set the mode for continuing the execution of multiple processes.
> 
> ? I think that "continuing" may trigger confusion by making it
> look like only the "continue" command is affected.  See new patch below.

How about "resuming the execution", then?

> > > +The final set of threads that are allowed to run by execution commands
> > > +is defined by the union of the restrictions implied by both the
> > > +@code{schedule-multiple} and @code{scheduler-locking} modes.  E.g., if
> > > +the @code{schedule-multiple} mode is set to @code{on}, but the
> > > +scheduler locking mode is also set to @code{on}, then only the current
> > > +thread is made schedulable.
> > 
> > It might be easier and simpler to tell that scheduler-locking takes
> > precedence.
> 
> It does not really take scrict precedence, due to the "step" scheduler-locking
> variant.

You could say that it takes precedence when set to ON.

Thanks, the new patch for the manual and the NEWS entry are fine with
me, but please consider the two remaining issues mentioned above.


  reply	other threads:[~2009-05-30 17:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-30 10:51 Pedro Alves
2009-05-30 13:10 ` Eli Zaretskii
2009-05-30 16:01   ` Pedro Alves
2009-05-30 17:12     ` Eli Zaretskii [this message]
2009-06-08 11:59       ` Pedro Alves
2009-06-09  4:01         ` Eli Zaretskii
2009-06-11 11:59           ` Pedro Alves
2009-05-31 16:34 ` Doug Evans
2009-05-31 16:40   ` Doug Evans
2009-05-31 18:31   ` Tom Tromey
2009-05-31 18:38     ` Doug Evans
2009-05-31 22:06     ` Pedro Alves
2009-06-01 15:55       ` Doug Evans
2009-06-03 14:06         ` Pedro Alves
2009-06-01 14:29 ` Marc Khouzam
2009-06-03 13:49   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83d49q4is6.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=marc.khouzam@ericsson.com \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox