From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70054-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13474 invoked by alias); 8 Feb 2010 18:38:27 -0000
Received: (qmail 13462 invoked by uid 22791); 8 Feb 2010 18:38:26 -0000
X-SWARE-Spam-Status: No, hits=0.0 required=5.0 	tests=AWL,BAYES_00,RCVD_IN_JMF_BL,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Feb 2010 18:38:21 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KXJ00H00CY1WW00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Mon, 08 Feb 2010 20:37:37 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.70.67.249]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KXJ00EP2D2MT5B0@a-mtaout22.012.net.il>; Mon, 08 Feb 2010 20:37:35 +0200 (IST)
Date: Mon, 08 Feb 2010 18:38:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: PATCH: Document i386 target features
In-reply-to: <20100208153337.GA25531@lucon.org>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83d40fefpm.fsf@gnu.org>
References: <20100208153337.GA25531@lucon.org>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-02/txt/msg00213.txt.bz2

> Date: Mon, 8 Feb 2010 07:33:37 -0800
> From: "H.J. Lu" <hongjiu.lu@intel.com>
> 
> Here is the patch to document i386 target features for i386 XML files
> I checked in.  OK to install?

Thanks, I have a few comments:

> +@cindex target descriptions, I386 features

Index entries are supposed to be mostly in lower case.  Would it be
okay to use "i386" instead of I386 here?

> +targets.  It should contain registers @samp{eax} through @samp{edi}
> +plus @samp{eip} for i386 and @samp{rax} through @samp{r15} plus
> +@samp{rip} for amd64, @samp{eflags}, @samp{cs}, @samp{ss}, @samp{ds},
> +@samp{es}, @samp{fs}, @samp{gs}, registers @samp{st0} through @samp{st7},
> +@samp{fctrl}, @samp{fstat}, @samp{ftag}, @samp{fiseg}, @samp{fioff},
> +@samp{foseg}, @samp{fooff} and @samp{fop}.

This list is very long, and makes the sentence long and hard to
grasp.  I think it would be more palatable as an itemized list, like
so:

 It should contain the following registers:

 @itemize @minus
 @item
 @samp{eax} through @samp{edi} and @samp{eip} for i386
 @item
 @samp{rax} through @samp{r15} plus @samp{rip} for amd64
 @item
 @samp{eflags}
 @item
 @samp{cs}, @samp{ss}, @samp{ds}, @samp{es}, @samp{fs}, @samp{gs}
 ...
 @end itemize

(I grouped related registers together to make the list shorter).

Btw, is it "contain the following registers" or "describe the
following registers"? 

> +They may be i386 or amd64 depending on the target.

Who are "they" here?