From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6027 invoked by alias); 2 Nov 2010 03:53:42 -0000 Received: (qmail 6019 invoked by uid 22791); 2 Nov 2010 03:53:41 -0000 X-SWARE-Spam-Status: No, hits=-0.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 02 Nov 2010 03:53:35 +0000 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LB800700NT1W000@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Tue, 02 Nov 2010 05:53:32 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.229.17.36]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LB8007VXO57SR40@a-mtaout21.012.net.il>; Tue, 02 Nov 2010 05:53:32 +0200 (IST) Date: Tue, 02 Nov 2010 03:53:00 -0000 From: Eli Zaretskii Subject: Re: [patch 2/2] Implement support for PowerPC BookE masked and ranged watchpoints In-reply-to: <1288648026.3377.7.camel@hactar> To: Thiago Jung Bauermann Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83d3qo5qkj.fsf@gnu.org> References: <1282074110.2606.703.camel@hactar> <1287807761.10521.423.camel@hactar> <838w1p8egs.fsf@gnu.org> <1288403952.2598.58.camel@hactar> <83wrp05f2f.fsf@gnu.org> <1288648026.3377.7.camel@hactar> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00015.txt.bz2 > From: Thiago Jung Bauermann > Cc: gdb-patches@sourceware.org > Date: Mon, 01 Nov 2010 19:47:06 -0200 > > What about this? > > /* The watchpoint will trigger if the address of the memory access is > within the defined range, as follows: p.addr <= address < p.addr2. > > Note that the above sentence just documents how ptrace interprets > its arguments; the watchpoint is set to watch the range defined by > the user _inclusively_, as specified by the user interface. */ That's fine, thanks. > +* GDB now supports ranged watchpoints, which stop the inferior when it > + accesses any address within a specified memory range. See the > + documentation on the watch-range command for more information. The > + watchpoint is hardware-accelerated on some targets (currently only when > + locally debugging programs on PowerPC BookE processors running a Linux > + kernel version 2.6.34 or later.) The last period should be outside the parentheses. > +* Also on native debugging on Linux running on PowerPC BookE, GDB supports ^^ "for" > + masked hardware watchpoints, which specifiy a mask in addition to an > + address to watch. The mask specifies that some bits of an address (the > + bits which are reset in the mask) should be ignored when matching the > + address accessed by the inferior against the watchpoint address. A pointer to the corresponding section in the manual would be good here. > +watch > + The watch command now supports the mask argument which allows creation > + of masked watchpoints, if the current architecture supports this feature. Instead of just "watch", I suggest to show here its form with a mask. OK with those changes.