From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15383 invoked by alias); 11 Aug 2011 16:21:30 -0000 Received: (qmail 15364 invoked by uid 22791); 11 Aug 2011 16:21:24 -0000 X-SWARE-Spam-Status: No, hits=-0.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_WEB,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 11 Aug 2011 16:20:56 +0000 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LPR00C00UMI8Y00@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Thu, 11 Aug 2011 19:20:54 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.228.94.185]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LPR00BFLUQTZQB0@a-mtaout23.012.net.il>; Thu, 11 Aug 2011 19:20:54 +0300 (IDT) Date: Thu, 11 Aug 2011 16:21:00 -0000 From: Eli Zaretskii Subject: Re: [python] [patch] set/show extended-prompt In-reply-to: To: pmuldoon@redhat.com Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83d3gbyl5j.fsf@gnu.org> References: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00237.txt.bz2 > From: Phil Muldoon > Date: Thu, 11 Aug 2011 16:06:45 +0100 > > > This patch adds extended-prompt capabilities to GDB. In addition it > adds a prompt substitution library. I made the extended-prompt lazily > control the prompt_hook on setting, over controlling it unconditionally. The > rest of the function remains the same other than in-Python documentation > as was found in Archer. Thanks, I have a few comments about the documentation part: > +@xref{gdb.prompt} for a list of the flags that can be used for ^ If you run "make info", it will complain here, because you need to add a comma after the right brace. > + The prompt is updated with the value of the > +flags each time it is displayed. Is "flags" a good term? I think "escape sequence" is better, e.g.: Any escape sequences specified as part of the prompt string are replaced with the corresponding strings each time the prompt is displayed. > +Note that when an extended-prompt is set, it takes control of the > +@var{prompt_hook} hook. @xref{prompt_hook} for further information. ^ Likewise, you need a comma here. > +@item show extended-prompt > +Prints the extended prompt. Each time the prompt is displayed, it is > +updated with the current value of the flags passed to it with ``set > +extended-prompt''. @code{set extended-prompt}. And the same comment about "flags" applies here as well. > +@smallexample > +substitute_prompt (``frame: \f, print arguments: \p@{print frame-arguments@}'') > +@end smallexample The line inside @example should be broken into two, as it is too long. > +will return the string: This line needs an @exdent before it, because it is not a new paragraph. > +@smallexample > +``frame: main, print arguments: scalars'' > +@end smallexample Aren't these ``..'' quotes left verbatim in the printed version of the manual? I think you need literal ".." quotes here, since they are not converted inside @smallexample.