Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Hui Zhu <hui_zhu@mentor.com>
Cc: gdb-patches@sourceware.org, Yao_Qi@mentor.com, stan_shebs@mentor.com
Subject: Re: [PATCH] Autoload-breakpoints without report-async
Date: Fri, 04 May 2012 07:02:00 -0000	[thread overview]
Message-ID: <83d36k77od.fsf@gnu.org> (raw)
In-Reply-To: <4FA32A2E.20801@mentor.com>

> Date: Fri, 4 May 2012 09:00:30 +0800
> From: Hui Zhu <hui_zhu@mentor.com>
> CC: <gdb-patches@sourceware.org>, <Yao_Qi@mentor.com>, <stan_shebs@mentor.com>
> 
> Oops, I post the wrong version.  The attachment is the right version.  Please help me review it.
> +@item set breakpoint autoload query
> +If this option is @samp{query} (the default), @value{GDBN} will query to user
                                                                   ^^^^^^^^^^^^^
"query the user"

> +how to handle the autoload-breakpoints when @value{GDBN} connect to the stub.
                                                            ^^^^^^^
"connects"

> +@item set breakpoint autoload stub
> +If this option is @samp{stub}, the autoload-breakpoints of GDB will be removed
                                                              ^^^
"@value{GDBN}"

> +@item @samp{QBDP}@var{autoload-breakpoints base format}
> +@value{GDBN} use this packet to control the autoload-breakpoints in the remote.
                ^^^
"uses"

> +@table @samp
> +
> +@item @var{id}@samp{:}@var{command}@samp{:}@var{addr_string}@samp{:}@var{type}@samp{:}@var{ignore_num}

The whole table uses @samp as the default typeface, so you don't need
@samp in the @item line.  Every piece of text there that doesn't have
an explicit markup will be typeset as @samp automatically.

> +@item @var{id}
> +This is the id in hex string format of this command want to control.
> +this command wants to control.

 This is the id in hex string format of the breakpoint to which to
 apply this command.

> +                       @value{GDBN} will create this breakpoint as
> +it have been created in the target.  So when the target creates the
> +breakpoint, it needs to insert this breakpoint by itself.

  @value{GDBN} will assume the breakpoint already exists and is
  inserted in the remote, so the target needs to insert the breakpoint
  when it creates it.

> +When @value{GDBN} or the target get this packet, it will delete
> +the autoload-breakpoint @var{id}.                ^^^^^^^^^^^^^^

"they will delete"

OK with these changes.

Thanks.


  reply	other threads:[~2012-05-04  7:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-03 16:37 Hui Zhu
2012-05-03 17:03 ` Eli Zaretskii
2012-05-04  1:00   ` Hui Zhu
2012-05-04  7:02     ` Eli Zaretskii [this message]
2012-05-06  1:53       ` Hui Zhu
2012-05-07 19:40         ` Eli Zaretskii
2012-05-15 11:29 ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83d36k77od.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=Yao_Qi@mentor.com \
    --cc=gdb-patches@sourceware.org \
    --cc=hui_zhu@mentor.com \
    --cc=stan_shebs@mentor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox