From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17889 invoked by alias); 18 Apr 2013 16:02:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17877 invoked by uid 89); 18 Apr 2013 16:02:45 -0000 X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL,TW_DJ,TW_GP,TW_JG autolearn=no version=3.3.1 Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 18 Apr 2013 16:02:43 +0000 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MLG00H00KEOXV00@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Thu, 18 Apr 2013 19:02:40 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MLG00HTAKKGPBC0@a-mtaout23.012.net.il>; Thu, 18 Apr 2013 19:02:40 +0300 (IDT) Date: Fri, 19 Apr 2013 14:28:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH 13/26] serial_write: change prototype to take a void-pointer buffer. In-reply-to: <516FD45D.3020209@redhat.com> To: Pedro Alves Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83d2tr3jyl.fsf@gnu.org> References: <20130411225847.16791.29283.stgit@brno.lan> <20130411230030.16791.28557.stgit@brno.lan> <5167DF5F.8060701@redhat.com> <516FD45D.3020209@redhat.com> X-SW-Source: 2013-04/txt/msg00572.txt.bz2 > Date: Thu, 18 Apr 2013 12:09:17 +0100 > From: Pedro Alves > CC: gdb-patches@sourceware.org > > Eli, this patch touches ser-go32.c. Is it OK? > > Most recent version here: > > http://sourceware.org/ml/gdb-patches/2013-04/msg00364.html Oops, sorry. I've seen this at the time, but didn't realize I needed to approve it. Yes, OK, please go ahead. > I've now installed a cross djgpp toolchain (gcc 4.7.2) on my Fedora 17 > machine (*), and verified this causes no build regressions. I stumbled > on a couple unrelated preexisting issues I had to hack around, but GDB > built. Moreover, djgpp is -Wpointer-sign clean too with the whole > series applied. Thanks.