From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-104171-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11064 invoked by alias); 9 Aug 2013 14:06:21 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 11039 invoked by uid 89); 9 Aug 2013 14:06:20 -0000
X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RDNS_NONE,SPF_SOFTFAIL autolearn=no version=3.3.1
Received: from Unknown (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 09 Aug 2013 14:06:16 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MR900C00OGUPG00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 09 Aug 2013 17:05:31 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MR900CCKOH7I780@a-mtaout22.012.net.il>; Fri, 09 Aug 2013 17:05:31 +0300 (IDT)
Date: Fri, 09 Aug 2013 14:06:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFC] Add new commands to windows native code.
In-reply-to: <"001f01ce9413$72450b20$56cf2160$@muller"@ics-cnrs.unistra.fr>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83d2pnrmbn.fsf@gnu.org>
References: <"001f01ce9413$72450b20$56cf2160$@muller"@ics-cnrs.unistra.fr>
X-SW-Source: 2013-08/txt/msg00265.txt.bz2

> From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> Date: Thu, 8 Aug 2013 10:44:08 +0200
> 
>   This patch adds three new commands to windows native code:
> these are three Boolean set/show commands :
> 
> 1) set print-first-chance-exception on/off
> to also print a "gdb: unknown target exception ..."
> string on each first-chance exception.
> 
> 2) set stop-on-first-chance-exception on/off
> to stop code execution each time a first chance exception occurs.
> and
> 3) set stop-on-debug-string-event on/off
> to stop code execution each time a debug string event occurs.
> 
>   The third command was particularly useful to 
> understand and eliminate a msvcrt debug string event generated 
> by GDB code (fix to be submitted in a next patch).

I agree that these are useful features, but I would think they are
more appropriate as part of "catch" implementation for Windows.  For
starters, treating these as catchpoints will allow to use all the
features of catchpoints: ignore counts, commands, display in "info
breakpoints", etc.

So would you like to rewrite this as subcommands of "catch"?  E.g.,
how about

  . catch exception [NAME]

    will stop when a specified exception (default: any exception) is
    detected

  . catch debug-string

    will stop whenever any debug string event is detected.

In any case, these are user-visible changes, so they will require
updates to the user manual.

Thanks.