From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2113 invoked by alias); 14 Mar 2014 11:47:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2094 invoked by uid 89); 14 Mar 2014 11:47:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout22.012.net.il Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Mar 2014 11:47:35 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0N2F00E00CEMRP00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 14 Mar 2014 13:47:33 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N2F00EB7CQST100@a-mtaout22.012.net.il>; Fri, 14 Mar 2014 13:47:16 +0200 (IST) Date: Fri, 14 Mar 2014 11:47:00 -0000 From: Eli Zaretskii Subject: Re: [RFC PATCH] Allow disabling the default run target. In-reply-to: <5322E2B8.8080808@redhat.com> To: Pedro Alves Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83d2hpc88v.fsf@gnu.org> References: <1394737368-29334-1-git-send-email-palves@redhat.com> <83y50dn9aj.fsf@gnu.org> <5322E2B8.8080808@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00329.txt.bz2 > Date: Fri, 14 Mar 2014 11:06:32 +0000 > From: Pedro Alves > CC: gdb-patches@sourceware.org > > On 03/13/2014 08:16 PM, Eli Zaretskii wrote: > >> From: Pedro Alves > >> Date: Thu, 13 Mar 2014 19:02:48 +0000 > >> > >> Wonder what people think of this. > > > > FWIW, the names of commands and options confused me a lot. > > Thanks Eli. I battled with several different namings, and > all the others seemed worse. :-) But I do think we should > try to come up with something better -- always a bad sign > to me when a GDB maintainer is confused. Probably users > will be even more. > > Can you point out specifically what confused you? "target child" itself, and then the apparent disconnect between that and the option name, although NEWS says that "'target child' [...] connects to the default run target". Also, the fact that setting default-run-target to OFF actually _enables_ something (AFAIU). > I've been pondering renaming "target child" to something else. > "child" is a little lie in case of "attach". > By best suggestion so far is "target native". "target native" is a much better name, IMO. > Not sure whether djgpp even supports remote debugging AFAIK, it does, see ser-go32.c. But if you meant remote debugging of DJGPP programs, then no, this isn't supported, since gdbserver doesn't, and there's no other stub that could do that instead. > I'd suggest just removing go32_open, and letting inf-child.c's > to_open handle pushing the target. Fine with me. I don't think "target djgpp" was ever important anyway, I think it's there mostly for completeness. > For the toggle option itself, I considered putting "enable" in the name: > > set enable-default-run-target > > But disabling this isn't really disabling the target, only > the falling back is disabled. Adding "fallback" and/to "to" > seems to help. Like: > > set enable-fallback-to-default-run-target > set enable-fallback-default-run-target > set fallback-to-default-run-target > set fallback-default-run-target > > Seemed a little too long, so I ended up dropping the "fallback". > Dunno, maybe tab completion makes that a non-issue. > > Assuming using "native" instead would be OK, I think we could > dispense with "default", like: > > set enable-fallback-to-native-target > set enable-fallback-native-target > set fallback-to-native-target > set fallback-native-target > set native-target-fallback > > (and then "target child" renamed to "target native"). Maybe we should take a step back and discuss why this fallback is useful. Is it only so native debugging works by default without a need to say "target native"?