From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1528 invoked by alias); 13 Aug 2014 18:02:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1511 invoked by uid 89); 13 Aug 2014 18:02:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout21.012.net.il Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Aug 2014 18:02:49 +0000 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NA900E00BD9C600@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Wed, 13 Aug 2014 21:02:46 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NA900EOVBGL4X80@a-mtaout21.012.net.il>; Wed, 13 Aug 2014 21:02:46 +0300 (IDT) Date: Wed, 13 Aug 2014 18:02:00 -0000 From: Eli Zaretskii Subject: Re: Warnings in native MinGW32 build of GDB 7.8 In-reply-to: <20140813174227.GF4881@adacore.com> To: Joel Brobecker Cc: yao@codesourcery.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83d2c4i7y2.fsf@gnu.org> References: <83r40plpp3.fsf@gnu.org> <53EAE47A.6030700@codesourcery.com> <83k36cifeq.fsf@gnu.org> <20140813174227.GF4881@adacore.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00242.txt.bz2 > Date: Wed, 13 Aug 2014 10:42:27 -0700 > From: Joel Brobecker > Cc: Yao Qi , gdb-patches@sourceware.org > > > > > #include "defs.h" > > > > +#include "target.h" /* for 'enum target_xfer_status' */ > > > > > > I can see enum target_xfer_status is used in this c file. This is good > > > to me. > > > > Not sure what you mean here. Do you agree with this change? If not, > > why not? > > I think Yao was agreeing with the patch. I agree with the change > as well, so you can commit that part right away. > > > > > /* Dynamic target-system-dependent parameters for GDB. */ > > > > +#include "frame.h" /* for 'struct frame_id' */ > > > > > > It is unclear to me why do we need this include? > > > > Because 'struct frame_id' is otherwise not defined, and I get warnings > > like this one: > > > > In file included from defs.h:631, > > from gdb.c:19: > > gdbarch.h:429: warning: parameter has incomplete type > > gdbarch.h:430: warning: parameter has incomplete type > > I think we should fix gdbarch.h to include frame.h instead, which > effectively means adjusting gdbarch.sh. The solution you chose seems > to be relying on an indirect include, which we really really try > to avoid. Yao's question is a good example of one of the reasons > why we avoid that; but there is also the fact that not everyone > will need frame.h's declarations. > > > > > --- gdb/target-dcache.c~0 2014-06-11 19:34:41.000000000 +0300 > > > > +++ gdb/target-dcache.c 2014-08-09 16:17:42.244875000 +0300 > > > > @@ -16,6 +16,7 @@ > > > > along with this program. If not, see . */ > > > > > > > > #include "defs.h" > > > > +#include "target.h" /* for 'enum target_xfer_status' */ > > > > > > enum target_xfer_status isn't used in target-dcache.c. Do we really > > > need this? > > > > It is used in dcache.h which target-dcache.c includes: > > > > In file included from target-dcache.h:21, > > from target-dcache.c:19: > > dcache.h:42: warning: parameter has incomplete type > > Same here, dcache.h should be the one including target.h. I can do the 1st and the 3rd parts, but I'd prefer not to touch gdbarch.sh. Could one of you please do that? TIA