From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-116599-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15880 invoked by alias); 10 Oct 2014 18:18:41 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 15780 invoked by uid 89); 10 Oct 2014 18:18:40 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,LIKELY_SPAM_BODY,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout26.012.net.il
Received: from mtaout26.012.net.il (HELO mtaout26.012.net.il) (80.179.55.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Oct 2014 18:18:39 +0000
Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0ND800B00PAR5F00@mtaout26.012.net.il> for gdb-patches@sourceware.org; Fri, 10 Oct 2014 21:16:49 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0ND80058WQS1IP90@mtaout26.012.net.il>; Fri, 10 Oct 2014 21:16:49 +0300 (IDT)
Date: Fri, 10 Oct 2014 18:18:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH V2 8/9] Documentation for DTrace USDT probes.
In-reply-to: <1412961772-16249-9-git-send-email-jose.marchesi@oracle.com>
To: "Jose E. Marchesi" <jose.marchesi@oracle.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83d29zaivh.fsf@gnu.org>
References: <1412961772-16249-1-git-send-email-jose.marchesi@oracle.com> <1412961772-16249-9-git-send-email-jose.marchesi@oracle.com>
X-IsSubscribed: yes
X-SW-Source: 2014-10/txt/msg00275.txt.bz2

> From: "Jose E. Marchesi" <jose.marchesi@oracle.com>
> Date: Fri, 10 Oct 2014 19:22:51 +0200
> 
> This patch modifies the `Static Probe Points' section on the GDB
> manual in order to cover the support for DTrace USDT probes, in
> addition to SystemTap SDT probes.

Thanks.

> -Currently, @code{SystemTap} (@uref{http://sourceware.org/systemtap/})
> -@acronym{SDT} probes are supported on ELF-compatible systems.  See
> +@itemize @bullet
> +@item @code{SystemTap} (@uref{http://sourceware.org/systemtap/})
> +@acronym{SDT} probes@footnote{See
>  @uref{http://sourceware.org/systemtap/wiki/AddingUserSpaceProbingToApps}
> -for more information on how to add @code{SystemTap} @acronym{SDT} probes
> -in your applications.
> +for more information on how to add @code{SystemTap} @acronym{SDT}
> +probes in your applications.}.  @code{SystemTap} probes are usable
> +from assembly, C and C@t{++} languages@footnote{See
> +@uref{http://sourceware.org/systemtap/wiki/UserSpaceProbeImplementation}
> +for a good reference on how the @acronym{SDT} probes are implemented.}.  
> +@item @code{DTrace} (@uref{http://oss.oracle.com/projects/DTrace})
> +@acronym{USDT} probes.  @code{DTrace} probes are usable from C and
> +C@t{++} languages.
> +@end itemize

Please insert an empty line before each @item in the above list.

> +the semaphore.  @code{DTrace} probes do not support the notion of
> +semaphores.     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   ^^^^^^^^^^

I thought we agreed on a different wording of this.

> +probe being handled.  Some @code{DTrace} probes can be enabled or
> +disabled, but @code{SystemTap} probes do not support these notions.

Likewise here.